Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 18496002: Factor out OSR-related graph-building functionality from hydrogen.cc. (Closed)

Created:
7 years, 5 months ago by titzer
Modified:
7 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Factor out OSR-related graph-building functionality from hydrogen.cc. BUG= Committed: https://code.google.com/p/v8/source/detail?r=15488

Patch Set 1 #

Total comments: 1

Patch Set 2 : Extract HOsrBuilder declaration to its own header file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -118 lines) Patch
M src/hydrogen.h View 1 6 chunks +11 lines, -19 lines 0 comments Download
M src/hydrogen.cc View 1 10 chunks +12 lines, -82 lines 0 comments Download
A + src/hydrogen-osr.h View 1 1 chunk +28 lines, -17 lines 0 comments Download
A src/hydrogen-osr.cc View 1 1 chunk +123 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
This is a refactoring CL that moves OSR-related hydrogen stuff out of the main hydrogen.cc ...
7 years, 5 months ago (2013-07-02 08:55:44 UTC) #1
Michael Starzinger
LGTM with one comment. https://codereview.chromium.org/18496002/diff/1/src/hydrogen.h File src/hydrogen.h (right): https://codereview.chromium.org/18496002/diff/1/src/hydrogen.h#newcode1423 src/hydrogen.h:1423: class HOsrBuilder { Since the ...
7 years, 5 months ago (2013-07-03 10:54:12 UTC) #2
titzer
On 2013/07/03 10:54:12, Michael Starzinger wrote: > LGTM with one comment. > > https://codereview.chromium.org/18496002/diff/1/src/hydrogen.h > ...
7 years, 5 months ago (2013-07-04 08:53:36 UTC) #3
titzer
7 years, 5 months ago (2013-07-04 09:20:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15488 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698