Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: src/hydrogen-osr.h

Issue 18496002: Factor out OSR-related graph-building functionality from hydrogen.cc. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Extract HOsrBuilder declaration to its own header file. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-osr.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #ifndef V8_HYDROGEN_UINT32_ANALYSIS_H_ 28 #ifndef V8_HYDROGEN_OSR_H_
29 #define V8_HYDROGEN_UINT32_ANALYSIS_H_ 29 #define V8_HYDROGEN_OSR_H_
30 30
31 #include "hydrogen.h" 31 #include "hydrogen.h"
32 #include "ast.h"
33 #include "zone.h"
32 34
33 namespace v8 { 35 namespace v8 {
34 namespace internal { 36 namespace internal {
35 37
38 // Responsible for building graph parts related to OSR and otherwise
39 // setting up the graph to do an OSR compile.
40 class HOsrBuilder : public ZoneObject {
41 public:
42 explicit HOsrBuilder(HOptimizedGraphBuilder* builder)
43 : builder_(builder),
44 osr_entry_(NULL),
45 osr_loop_entry_(NULL),
46 osr_values_(NULL) { }
47 // Creates the loop entry block for the given statement, setting up OSR
48 // entries as necessary, and sets the current block to the new block.
49 HBasicBlock* BuildPossibleOsrLoopEntry(IterationStatement* statement);
36 50
37 // Discover instructions that can be marked with kUint32 flag allowing 51 // Process the hydrogen graph after it has been completed, performing
38 // them to produce full range uint32 values. 52 // any OSR-specific cleanups or changes.
39 class HUint32AnalysisPhase : public HPhase { 53 void FinishGraph();
40 public:
41 explicit HUint32AnalysisPhase(HGraph* graph)
42 : HPhase("H_Compute safe UInt32 operations", graph), phis_(4, zone()) { }
43 54
44 void Run(); 55 // Process the OSR values and phis after initial graph optimization.
56 void FinishOsrValues();
45 57
46 private: 58 private:
47 INLINE(bool IsSafeUint32Use(HValue* val, HValue* use)); 59 HBasicBlock* BuildLoopEntry();
48 INLINE(bool Uint32UsesAreSafe(HValue* uint32val)); 60 bool HasOsrEntryAt(IterationStatement* statement);
49 INLINE(bool CheckPhiOperands(HPhi* phi));
50 INLINE(void UnmarkPhi(HPhi* phi, ZoneList<HPhi*>* worklist));
51 INLINE(void UnmarkUnsafePhis());
52 61
53 ZoneList<HPhi*> phis_; 62 HOptimizedGraphBuilder* builder_;
63 HBasicBlock* osr_entry_;
64 HBasicBlock* osr_loop_entry_;
65 ZoneList<HUnknownOSRValue*>* osr_values_;
54 }; 66 };
55 67
56
57 } } // namespace v8::internal 68 } } // namespace v8::internal
58 69
59 #endif // V8_HYDROGEN_UINT32_ANALYSIS_H_ 70 #endif // V8_HYDROGEN_OSR_H_
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-osr.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698