[Sync] Add cookie jar mismatch logging

[Sync] Add cookie jar mismatch logging

Adds a listener to gaia cookie jar state, which plumbs that down into the
sync context. Cookie jar mismatch state is then sent up on every commit
message, which is then used server-side to ensure improve privacy.

BUG=599593
Committed: https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e
Cr-Commit-Position: refs/heads/master@{#385228}

[Nicolas Zea, 2016-04-01 21:12:44]

zea@chromium.org changed reviewers:
+ maxbogue@chromium.org

[Nicolas Zea, 2016-04-01 21:12:44]

+Max, PTAL

[Nicolas Zea, 2016-04-01 21:13:02]

+Kevin FYI

[maxbogue, 2016-04-01 22:30:48]

lgtm w/ nits!

Could you update either the commit message or the bug with a motivation for
doing this? Also, looks like you need to update SyncBackendHostMock.

https://codereview.chromium.org/1849563005/diff/20001/components/browser_sync...
File components/browser_sync/browser/profile_sync_service.cc (right):

https://codereview.chromium.org/1849563005/diff/20001/components/browser_sync...
components/browser_sync/browser/profile_sync_service.cc:2119: for (auto& iter :
accounts) {
const auto& account? iter doesn't really make sense since it's not an iterator.

https://codereview.chromium.org/1849563005/diff/20001/components/browser_sync...
File components/browser_sync/browser/profile_sync_service.h (right):

https://codereview.chromium.org/1849563005/diff/20001/components/browser_sync...
components/browser_sync/browser/profile_sync_service.h:958: // The gaia cookie
manager.
This comment isn't particularly useful. Could you say something about it
managing being signed in to the content area?

https://codereview.chromium.org/1849563005/diff/20001/sync/protocol/sync.proto
File sync/protocol/sync.proto (right):

https://codereview.chromium.org/1849563005/diff/20001/sync/protocol/sync.prot...
sync/protocol/sync.proto:404: // Whether the account(s) present in the content
area's cookie jar matches the
s/matches/match... I think? Grammar with parentheticals is hard.

https://codereview.chromium.org/1849563005/diff/20001/sync/protocol/sync.prot...
sync/protocol/sync.proto:405: // chrome account. If multiple accounts a present
in the cookie jar, a
are present

https://codereview.chromium.org/1849563005/diff/20001/sync/protocol/sync.prot...
sync/protocol/sync.proto:406: // mismatch implies all of them must are different
from the chrome account
s/must//, and add a period.

https://codereview.chromium.org/1849563005/diff/20001/sync/sessions/sync_sess...
File sync/sessions/sync_session_context.h (right):

https://codereview.chromium.org/1849563005/diff/20001/sync/sessions/sync_sess...
sync/sessions/sync_session_context.h:191: // Whether the account(s) present in
the content area's cookie jar matches the
All the same comments as for the proto.

https://codereview.chromium.org/1849563005/diff/20001/sync/test/fake_server/f...
File sync/test/fake_server/fake_server.h (right):

https://codereview.chromium.org/1849563005/diff/20001/sync/test/fake_server/f...
sync/test/fake_server/fake_server.h:54: // Helpers for fetching the last Commit
or Getupdates messages, respectively.
s/Getupdates/GetUpdates

[Nicolas Zea, 2016-04-04 19:56:30]

Description was changed from

==========
[Sync] Add cookie jar mismatch logging

Adds a listener to gaia cookie jar state, which plumbs that down into the
sync context. Cookie jar mismatch state is then sent up on every commit
message.

BUG=599593
==========

to

==========
[Sync] Add cookie jar mismatch logging

Adds a listener to gaia cookie jar state, which plumbs that down into the
sync context. Cookie jar mismatch state is then sent up on every commit
message, which is then used server-side.

BUG=599593
==========

[Nicolas Zea, 2016-04-04 19:57:13]

Description was changed from

==========
[Sync] Add cookie jar mismatch logging

Adds a listener to gaia cookie jar state, which plumbs that down into the
sync context. Cookie jar mismatch state is then sent up on every commit
message, which is then used server-side.

BUG=599593
==========

to

==========
[Sync] Add cookie jar mismatch logging

Adds a listener to gaia cookie jar state, which plumbs that down into the
sync context. Cookie jar mismatch state is then sent up on every commit
message, which is then used server-side to ensure improve privacy.

BUG=599593
==========

[Nicolas Zea, 2016-04-04 19:57:31]

Thanks!

https://codereview.chromium.org/1849563005/diff/20001/components/browser_sync...
File components/browser_sync/browser/profile_sync_service.cc (right):

https://codereview.chromium.org/1849563005/diff/20001/components/browser_sync...
components/browser_sync/browser/profile_sync_service.cc:2119: for (auto& iter :
accounts) {
On 2016/04/01 22:30:48, maxbogue wrote:
> const auto& account? iter doesn't really make sense since it's not an
iterator.

Done.

https://codereview.chromium.org/1849563005/diff/20001/components/browser_sync...
File components/browser_sync/browser/profile_sync_service.h (right):

https://codereview.chromium.org/1849563005/diff/20001/components/browser_sync...
components/browser_sync/browser/profile_sync_service.h:958: // The gaia cookie
manager.
On 2016/04/01 22:30:48, maxbogue wrote:
> This comment isn't particularly useful. Could you say something about it
> managing being signed in to the content area?

Done.

https://codereview.chromium.org/1849563005/diff/20001/sync/protocol/sync.proto
File sync/protocol/sync.proto (right):

https://codereview.chromium.org/1849563005/diff/20001/sync/protocol/sync.prot...
sync/protocol/sync.proto:404: // Whether the account(s) present in the content
area's cookie jar matches the
On 2016/04/01 22:30:48, maxbogue wrote:
> s/matches/match... I think? Grammar with parentheticals is hard.

Done.

https://codereview.chromium.org/1849563005/diff/20001/sync/protocol/sync.prot...
sync/protocol/sync.proto:405: // chrome account. If multiple accounts a present
in the cookie jar, a
On 2016/04/01 22:30:48, maxbogue wrote:
> are present

Done.

https://codereview.chromium.org/1849563005/diff/20001/sync/protocol/sync.prot...
sync/protocol/sync.proto:406: // mismatch implies all of them must are different
from the chrome account
On 2016/04/01 22:30:48, maxbogue wrote:
> s/must//, and add a period.

Done.

https://codereview.chromium.org/1849563005/diff/20001/sync/sessions/sync_sess...
File sync/sessions/sync_session_context.h (right):

https://codereview.chromium.org/1849563005/diff/20001/sync/sessions/sync_sess...
sync/sessions/sync_session_context.h:191: // Whether the account(s) present in
the content area's cookie jar matches the
On 2016/04/01 22:30:48, maxbogue wrote:
> All the same comments as for the proto.

Done.

https://codereview.chromium.org/1849563005/diff/20001/sync/test/fake_server/f...
File sync/test/fake_server/fake_server.h (right):

https://codereview.chromium.org/1849563005/diff/20001/sync/test/fake_server/f...
sync/test/fake_server/fake_server.h:54: // Helpers for fetching the last Commit
or Getupdates messages, respectively.
On 2016/04/01 22:30:48, maxbogue wrote:
> s/Getupdates/GetUpdates

Done.

[Nicolas Zea, 2016-04-04 19:57:48]

The CQ bit was checked by zea@chromium.org

[Nicolas Zea, 2016-04-04 19:57:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/1849563005/#ps60001
(title: "Really fix")

[commit-bot: I haz the power, 2016-04-04 19:58:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849563005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849563005/60001

[commit-bot: I haz the power, 2016-04-04 20:44:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 20:44:25]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nicolas Zea, 2016-04-05 00:55:28]

The CQ bit was checked by zea@chromium.org

[Nicolas Zea, 2016-04-05 00:55:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/1849563005/#ps80001
(title: "Fix tests again")

[commit-bot: I haz the power, 2016-04-05 00:56:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849563005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849563005/80001

[commit-bot: I haz the power, 2016-04-05 07:05:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 07:05:50]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Nicolas Zea, 2016-04-05 17:25:56]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2016-04-05 17:26:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849563005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849563005/80001

[Nicolas Zea, 2016-04-05 17:46:35]

The CQ bit was unchecked by zea@chromium.org

[Nicolas Zea, 2016-04-05 17:47:31]

The CQ bit was checked by zea@chromium.org

[commit-bot: I haz the power, 2016-04-05 17:48:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849563005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849563005/80001

[commit-bot: I haz the power, 2016-04-05 18:21:20]

Description was changed from

==========
[Sync] Add cookie jar mismatch logging

Adds a listener to gaia cookie jar state, which plumbs that down into the
sync context. Cookie jar mismatch state is then sent up on every commit
message, which is then used server-side to ensure improve privacy.

BUG=599593
==========

to

==========
[Sync] Add cookie jar mismatch logging

Adds a listener to gaia cookie jar state, which plumbs that down into the
sync context. Cookie jar mismatch state is then sent up on every commit
message, which is then used server-side to ensure improve privacy.

BUG=599593
==========

[commit-bot: I haz the power, 2016-04-05 18:21:21]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-05 18:22:47]

Description was changed from

==========
[Sync] Add cookie jar mismatch logging

Adds a listener to gaia cookie jar state, which plumbs that down into the
sync context. Cookie jar mismatch state is then sent up on every commit
message, which is then used server-side to ensure improve privacy.

BUG=599593
==========

to

==========
[Sync] Add cookie jar mismatch logging

Adds a listener to gaia cookie jar state, which plumbs that down into the
sync context. Cookie jar mismatch state is then sent up on every commit
message, which is then used server-side to ensure improve privacy.

BUG=599593

Committed: https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e
Cr-Commit-Position: refs/heads/master@{#385228}
==========

[commit-bot: I haz the power, 2016-04-05 18:22:49]

Patchset 5 (id:??) landed as
https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e
Cr-Commit-Position: refs/heads/master@{#385228}