Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: components/crash/core/common/crash_keys.cc

Issue 1849413003: Define crash keys in the directory hierarchy where they are used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with head Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/core/common/crash_keys.h ('k') | components/nacl/broker/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/core/common/crash_keys.cc
diff --git a/components/crash/core/common/crash_keys.cc b/components/crash/core/common/crash_keys.cc
index 6c2d3828deee3ad3c6096a0f31431d026c476275..e42fa3f42c823f4764854a4eb992f8b6fa551989 100644
--- a/components/crash/core/common/crash_keys.cc
+++ b/components/crash/core/common/crash_keys.cc
@@ -134,6 +134,28 @@ void GetCrashKeysForCommandLineSwitches(
}
}
+void AppendCrashCrashKeys(std::vector<base::debug::CrashKey>* keys) {
+ DCHECK(keys);
+
+ const std::vector<base::debug::CrashKey> crash_keys = {
+#if defined(OS_MACOSX) || defined(OS_WIN)
+ { kMetricsClientId, kSmallSize },
+#else
+ { kClientId, kSmallSize },
+#endif
+ { kChannel, kSmallSize },
+ { kNumVariations, kSmallSize },
+ { kVariations, kLargeSize },
+#if defined(OS_MACOSX)
+ { mac::kZombie, kMediumSize },
+ { mac::kZombieTrace, kMediumSize },
+#endif
+ { kBug464926CrashKey, kSmallSize },
+ };
+
+ keys->insert(keys->end(), crash_keys.begin(), crash_keys.end());
+}
+
void SetSwitchesFromCommandLine(const base::CommandLine& command_line,
SwitchFilterFunction skip_filter) {
const base::CommandLine::StringVector& argv = command_line.argv();
« no previous file with comments | « components/crash/core/common/crash_keys.h ('k') | components/nacl/broker/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698