Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1849413003: Define crash keys in the directory hierarchy where they are used. (Closed)

Created:
4 years, 8 months ago by marcinjb
Modified:
3 years, 10 months ago
Reviewers:
halliwell
CC:
chromium-reviews, kalyank, feature-media-reviews_chromium.org, jam, sadrul, darin-cc_chromium.org, halliwell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define crash keys in the directory hierarchy where they are used. Currently, fixed crash keys are (for the most part) all defined in one large array in //chrome/common/crash_keys.cc. This leads to problems where users of crash will need to manually keep in sync with various changes to the active crash keys. Instead, fixed crash keys will be defined in the directory hierarchy where they're used (ie. //content, //media, etc...), and a new "Append<$COMPONENT>CrashKeys() function will be provided so that it's easy to get all keys for that component. Also, while at it, remove some unused crash keys. BUG=598854

Patch Set 1 #

Patch Set 2 : Added some dependencies to BUILD.gn files #

Patch Set 3 : Add missing gyp dependencies #

Patch Set 4 : Add exports for //media and //content #

Patch Set 5 : Add dependencies on new crash files in chrome_exe.gypi #

Patch Set 6 : Refinements on nacl64 target #

Patch Set 7 : Remove media crash keys source file from nacl64 build target #

Patch Set 8 : Add crash key dependency in //chrome/BUILD.gn #

Patch Set 9 : Added crash key targets in //content and //media #

Patch Set 10 : Add missing dependencies (::shamecube::) #

Patch Set 11 : Add build defs to nacl64 #

Patch Set 12 : Merge with head #

Patch Set 13 : Trying static crash keys definitions for //content/public/common:crash_keys #

Patch Set 14 : Make the crash_keys targets in //media/base and //content/public/common be considered an "implement… #

Patch Set 15 : Merge with head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -90 lines) Patch
M chrome/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 7 chunks +26 lines, -90 lines 0 comments Download
M components/crash/core/common/crash_keys.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/crash/core/common/crash_keys.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M components/nacl/broker/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +19 lines, -0 lines 0 comments Download
M content/public/common/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +3 lines, -0 lines 0 comments Download
A content/public/common/crash_keys.h View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
A content/public/common/crash_keys.cc View 1 chunk +98 lines, -0 lines 0 comments Download
M media/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +1 line, -0 lines 0 comments Download
M media/base/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +18 lines, -0 lines 0 comments Download
A media/base/crash_keys.h View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A media/base/crash_keys.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849413003/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849413003/190001
4 years, 8 months ago (2016-04-22 02:13:14 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 02:15:51 UTC) #5
Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698