Issue 1849343002: Followup to https://codereview.chromium.org/1849113003

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1849343002: Followup to https://codereview.chromium.org/1849113003 (Closed)

Created:
4 years, 8 months ago by iannucci

Modified:
4 years, 8 months ago

Reviewers:
dnj

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

More Reviews

Description

Followup to https://codereview.chromium.org/1849113003 Forgot to reupload before CQing TBR=dnj@chromium.org BUG=598958 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299643

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -27 lines)			Patch
	M	scripts/slave/recipes/infra/depot_tools_builder.py	View		3 chunks	+16 lines, -16 lines	0 comments	Download
	M	scripts/slave/recipes/infra/depot_tools_builder.expected/basic.json	View		12 chunks	+50 lines, -11 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849343002/1

4 years, 8 months ago (2016-04-01 18:59:05 UTC) #3

commit-bot: I haz the power

4 years, 8 months ago (2016-04-01 19:02:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299643

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages