Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 1849113003: Add depot_tools builder to infra waterfall. (Closed)

Created:
4 years, 8 months ago by iannucci
Modified:
4 years, 8 months ago
Reviewers:
dnj, agable
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add depot_tools builder to infra waterfall. This builder clones, packs, and zips depot_tools for the purpose of updating the windows depot_tools.zip bootstrap, and it also uploads the generated `man/html` documentation folder to the chrome-infra-docs bucket. R=agable@chromium.org, dnj@chromium.org BUG=598958 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299636

Patch Set 1 #

Patch Set 2 : add comments #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -0 lines) Patch
M masters/master.chromium.infra/master.cfg View 4 chunks +21 lines, -0 lines 0 comments Download
M masters/master.chromium.infra/slaves.cfg View 1 chunk +1 line, -0 lines 0 comments Download
A scripts/slave/recipes/infra/depot_tools_builder.py View 1 1 chunk +64 lines, -0 lines 6 comments Download
A scripts/slave/recipes/infra/depot_tools_builder.expected/basic.json View 1 chunk +183 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
iannucci
4 years, 8 months ago (2016-04-01 09:07:00 UTC) #1
dnj
lgtm w/ nits https://codereview.chromium.org/1849113003/diff/20001/scripts/slave/recipes/infra/depot_tools_builder.py File scripts/slave/recipes/infra/depot_tools_builder.py (right): https://codereview.chromium.org/1849113003/diff/20001/scripts/slave/recipes/infra/depot_tools_builder.py#newcode42 scripts/slave/recipes/infra/depot_tools_builder.py:42: api.git('clone', '--single-branch', '-n', REPO_URL, api.path['checkout']) nit: ...
4 years, 8 months ago (2016-04-01 14:40:01 UTC) #2
agable
Big top-level comment: You're putting this on the chromium.infra waterfall, but it doesn't run any ...
4 years, 8 months ago (2016-04-01 17:34:17 UTC) #3
iannucci
On 2016/04/01 at 17:34:17, agable wrote: > Big top-level comment: > You're putting this on ...
4 years, 8 months ago (2016-04-01 17:54:17 UTC) #4
iannucci
On 2016/04/01 at 17:54:17, iannucci wrote: > On 2016/04/01 at 17:34:17, agable wrote: > > ...
4 years, 8 months ago (2016-04-01 17:54:56 UTC) #5
iannucci
https://chromiumcodereview.appspot.com/1849113003/diff/20001/scripts/slave/recipes/infra/depot_tools_builder.py File scripts/slave/recipes/infra/depot_tools_builder.py (right): https://chromiumcodereview.appspot.com/1849113003/diff/20001/scripts/slave/recipes/infra/depot_tools_builder.py#newcode42 scripts/slave/recipes/infra/depot_tools_builder.py:42: api.git('clone', '--single-branch', '-n', REPO_URL, api.path['checkout']) On 2016/04/01 at 14:40:01, ...
4 years, 8 months ago (2016-04-01 18:01:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849113003/20001
4 years, 8 months ago (2016-04-01 18:01:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299636
4 years, 8 months ago (2016-04-01 18:05:56 UTC) #10
agable
4 years, 8 months ago (2016-04-01 18:30:59 UTC) #11
Message was sent while issue was closed.
Totally fine with this landing, just want to more clearly make my case:

On 2016/04/01 at 17:54:17, iannucci wrote:
> On 2016/04/01 at 17:34:17, agable wrote:
> > Big top-level comment:
> > You're putting this on the chromium.infra waterfall, but it doesn't run any
tests. In my opinion, either:
> > a) This should be on chromium.infra.cron, since it does a thing that should
be done regularly; or
> 
> It polls depot_tools, it's not a cron job

It doesn't have to poll depot_tools. It could run once an hour, or once a day,
and get essentially the same utility. And since this isn't compiling or testing
anything, it is pretty out of place on a CI waterfall.

> > b) This should be on chromium.infra, but run tests and only upload if the
tests pass.
> 
> The tests are meaningless and don't even work on windows.

So let's blacklist / whitelist the tests. Then we'll at least have a goal to
work towards.

> > In addition, it should (if at all possible) be a windows bot, since the zip
file is pretty much only used by windows devs.
> 
> Building this zip on windows is much more painful than on linux, and would
reduce the relocatability of this recipe.

Yeah, the "(if at all possible)" was because I was 99% sure that was a
infeasible long shot.

Anyway, totally understand what you're doing here, and *really* understand the
desire to just be done with it. It just seemed like this CL was a really good
time to get a head start on actually testing depot_tools like a real repo.

Powered by Google App Engine
This is Rietveld 408576698