Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 18493006: Use c++11 on clang/android (Closed)

Created:
7 years, 5 months ago by Nico
Modified:
7 years, 5 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, digit1, hans, awong, Yaron
Visibility:
Public.

Description

Use c++11 on clang/android stlport doesn't have any c++11 library features, but this turns on the language features. (With clang only, gcc is still in c++98 mode for now.) BUG=none R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211864

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fffff #

Patch Set 4 : . #

Patch Set 5 : doh #

Patch Set 6 : bettercomment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -22 lines) Patch
M build/common.gypi View 1 2 3 4 5 3 chunks +14 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 5 months ago (2013-07-16 00:24:19 UTC) #1
cjhopman
lgtm
7 years, 5 months ago (2013-07-16 18:05:19 UTC) #2
Nico
Thanks! I tweaked the CL slightly: 1.) I merged the two clang==1 blocks. 2.) I ...
7 years, 5 months ago (2013-07-16 22:31:22 UTC) #3
Nico
7 years, 5 months ago (2013-07-16 22:37:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #6 manually as r211864 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698