Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1292)

Unified Diff: build/common.gypi

Issue 18493006: Use c++11 on clang/android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: bettercomment Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 683fa815b790def5f4533a1c3f5adfcb1ac4eeaa..1f0b3d18d61a071e4fc464c2240db19d45b82e5e 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3137,15 +3137,9 @@
# Warns when a const char[] is converted to bool.
'-Wstring-conversion',
- ],
- 'cflags!': [
- # Clang doesn't seem to know know this flag.
- '-mfpmath=sse',
- ],
- }],
- ['clang==1 and OS!="android"', {
- # Turn on C++11.
- 'cflags': [
+
+ # C++11-related flags:
+
# This warns on using ints as initializers for floats in
# initializer lists (e.g. |int a = f(); CGSize s = { a, a };|),
# which happens in several places in chrome code. Not sure if
@@ -3163,6 +3157,10 @@
# http://crbug.com/255186
'-Wno-deprecated-register',
],
+ 'cflags!': [
+ # Clang doesn't seem to know know this flag.
+ '-mfpmath=sse',
+ ],
'cflags_cc': [
# See the comment in the Mac section for what it takes to move
# this to -std=c++11.
@@ -3170,19 +3168,13 @@
],
}],
['clang==1 and OS=="android"', {
- # Android uses gcc4.4, and clang isn't compatible with gcc4.4's
- # libstdc++ in C++11 mode. So no C++11 mode for Android yet.
- # Doesn't work with asan for some reason either: crbug.com/233464
- 'cflags': [
- # Especially needed for gtest macros using enum values from Mac
- # system headers.
- # TODO(pkasting): In C++11 this is legal, so this should be
- # removed when we change to that. (This is also why we don't
- # bother fixing all these cases today.)
- '-Wno-unnamed-type-template-args',
- # This (rightfully) complains about 'override', which we use
- # heavily.
- '-Wno-c++11-extensions',
+ # Android uses stlport, whose include/new defines
+ # `void operator delete[](void* ptr) throw();`, which
+ # clang's -Wimplicit-exception-spec-mismatch warns about for some
+ # reason -- http://llvm.org/PR16638. TODO(thakis): Include stlport
+ # via -isystem instead.
+ 'cflags_cc': [
+ '-Wno-implicit-exception-spec-mismatch',
],
}],
['clang==1 and clang_use_chrome_plugins==1', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698