Add kill switch for DRP config service

Add kill switch for DRP config service

Config client is enabled by default. It can be disabled only
if Chromium belongs to a field trial group whose name starts
with "Disabled".

BUG=597768
Committed: https://crrev.com/50cb614060239a1850c03dd88da4b5f8ae341dc2
Cr-Commit-Position: refs/heads/master@{#384751}

[tbansal1, 2016-04-01 16:44:05]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-04-01 16:44:56]

Description was changed from

==========
Kill switch for DRP config service

BUG=
==========

to

==========
Add kill switch for DRP config service

Config client is enabled by default. It can be disabled only 
if Chromium belongs to a field trial group whose name starts 
with "Disabled".

BUG=597768
==========

[tbansal1, 2016-04-01 16:59:59]

Patchset #1 (id:20001) has been deleted

[tbansal1, 2016-04-01 17:56:57]

tbansal@chromium.org changed reviewers:
+ sclittle@chromium.org

[tbansal1, 2016-04-01 17:56:58]

sclittle: ptal. Thanks.

[sclittle, 2016-04-01 18:34:18]

lgtm % nit

https://codereview.chromium.org/1849293002/diff/40001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/1849293002/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:192:
base::StringPiece group = group_value;
nit: You don't need to construct a separate base::StringPiece, you can just call
base::StartsWith(group_value, kDisabled, base::CompareCase::SENSITIVE);

[tbansal1, 2016-04-01 23:18:40]

Patchset #2 (id:60001) has been deleted

[tbansal1, 2016-04-01 23:19:02]

https://codereview.chromium.org/1849293002/diff/40001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/1849293002/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:192:
base::StringPiece group = group_value;
On 2016/04/01 18:34:18, sclittle wrote:
> nit: You don't need to construct a separate base::StringPiece, you can just
call
> base::StartsWith(group_value, kDisabled, base::CompareCase::SENSITIVE);

Done.

[tbansal1, 2016-04-01 23:19:06]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-04-01 23:19:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/1849293002/#ps80001
(title: "sclittle comment")

[commit-bot: I haz the power, 2016-04-01 23:19:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849293002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849293002/80001

[commit-bot: I haz the power, 2016-04-02 00:17:24]

Description was changed from

==========
Add kill switch for DRP config service

Config client is enabled by default. It can be disabled only 
if Chromium belongs to a field trial group whose name starts 
with "Disabled".

BUG=597768
==========

to

==========
Add kill switch for DRP config service

Config client is enabled by default. It can be disabled only 
if Chromium belongs to a field trial group whose name starts 
with "Disabled".

BUG=597768
==========

[commit-bot: I haz the power, 2016-04-02 00:17:25]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-04-02 00:19:00]

Description was changed from

==========
Add kill switch for DRP config service

Config client is enabled by default. It can be disabled only 
if Chromium belongs to a field trial group whose name starts 
with "Disabled".

BUG=597768
==========

to

==========
Add kill switch for DRP config service

Config client is enabled by default. It can be disabled only
if Chromium belongs to a field trial group whose name starts
with "Disabled".

BUG=597768

Committed: https://crrev.com/50cb614060239a1850c03dd88da4b5f8ae341dc2
Cr-Commit-Position: refs/heads/master@{#384751}
==========

[commit-bot: I haz the power, 2016-04-02 00:19:01]

Patchset 2 (id:??) landed as
https://crrev.com/50cb614060239a1850c03dd88da4b5f8ae341dc2
Cr-Commit-Position: refs/heads/master@{#384751}