Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc

Issue 1849293002: Add kill switch for DRP config service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sclittle comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
index 8ce9ecca692fc9338e32271f4881b2d675e0945d..f200033dcb3e42110fb03694d9240503e273ec41 100644
--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
@@ -26,6 +26,7 @@ namespace {
const char kEnabled[] = "Enabled";
const char kControl[] = "Control";
+const char kDisabled[] = "Disabled";
const char kPreview[] = "Enabled_Preview";
const char kDefaultSpdyOrigin[] = "https://proxy.googlezip.net:443";
const char kDefaultQuicOrigin[] = "quic://proxy.googlezip.net:443";
@@ -184,9 +185,11 @@ bool IsDevRolloutEnabled() {
}
bool IsConfigClientEnabled() {
- // TODO(tbansal): crbug.com/597768 Remove the data reduction proxy deprecated
- // code which was used when config client is not enabled.
- return true;
+ // Config client is enabled by default. It can be disabled only if Chromium
+ // belongs to a field trial group whose name starts with "Disabled".
+ return !base::StartsWith(
+ base::FieldTrialList::FindFullName("DataReductionProxyConfigService"),
+ kDisabled, base::CompareCase::SENSITIVE);
}
GURL GetConfigServiceURL() {
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698