third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3.html - Issue 1849223002: Blocking synchronous and third party doc.written scripts

Unified Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3.html

Issue 1849223002: Blocking synchronous and third party doc.written scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests modified as per feedback and code comments added Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block2.html ('K') | « third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block2-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3.html b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3.html

new file mode 100644

index 0000000000000000000000000000000000000000..137368d1fc8d1ee7afa94d8041fd0403b80c25f8

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3.html

@@ -0,0 +1,25 @@

+<!DOCTYPE html>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<script>

+ var src = 'http://localhost:8000/loading/resources/js-loaded.js';

jkarlin 2016/04/06 14:55:31 instead of ...-block3.html, how about ...-block-ne

+ var jsLoaded = false;

+ var loadSuccess = false;

+ if (window.internals){

+ internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(true);

+ internals.setNetworkStateNotifierTestOnly(true);

+ internals.setNetworkConnectionInfo('cellular3g', 2.0);

+ }

+ document.write('<scr' + 'ipt src="' + src + '" onload="loadsuccess=true"></scr' + 'ipt>');

Bryan McQuade 2016/04/06 12:37:21 looks like we have loadsuccess here but we are set

shivanisha 2016/04/06 14:18:36 Whoops. Made it loadSuccess in all places.

+</script>

+<script>

+ test(function () {

+ assert_true(jsLoaded);

+ assert_true(loadsuccess);

+ }, "Document.written scripts are not blocked in a fast connection");

+ window.addEventListener('beforeunload', function() {

+ internals.setNetworkStateNotifierTestOnly(false);

+ internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(false);

+ }, false);

+</script>