third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3.html - Issue 1849223002: Blocking synchronous and third party doc.written scripts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3.html

Issue 1849223002: Blocking synchronous and third party doc.written scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests modified as per feedback and code comments added Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block2.html ('K') | « third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block2-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>

	5 var src = 'http://localhost:8000/loading/resources/js-loaded.js';
	jkarlin 2016/04/06 14:55:31 instead of ...-block3.html, how about ...-block-ne instead of ...-block3.html, how about ...-block-network.html so it's clear which tests should go in this file
	6 var jsLoaded = false;

	7 var loadSuccess = false;

	8 if (window.internals){

	9 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(true) ;

	10 internals.setNetworkStateNotifierTestOnly(true);

	11 internals.setNetworkConnectionInfo('cellular3g', 2.0);

	12 }

	13 document.write('<scr' + 'ipt src="' + src + '" onload="loadsuccess=true"></s cr' + 'ipt>');
	Bryan McQuade 2016/04/06 12:37:21 looks like we have loadsuccess here but we are set looks like we have loadsuccess here but we are setting loadSuccess above. let's use loadSuccess everywhere. shivanisha 2016/04/06 14:18:36 Whoops. Made it loadSuccess in all places. Show quoted text On 2016/04/06 at 12:37:21, Bryan McQuade wrote: > looks like we have loadsuccess here but we are setting loadSuccess above. let's use loadSuccess everywhere. Whoops. Made it loadSuccess in all places.
	14 </script>

	15 <script>

	16 test(function () {

	17 assert_true(jsLoaded);

	18 assert_true(loadsuccess);

	19 }, "Document.written scripts are not blocked in a fast connection");

	20

	21 window.addEventListener('beforeunload', function() {

	22 internals.setNetworkStateNotifierTestOnly(false);

	23 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(false );

	24 }, false);

	25 </script>

OLD	NEW