Remove SK_SUPPORT_LEGACY_XFERMODE_PTR

Remove SK_SUPPORT_LEGACY_XFERMODE_PTR

Favor Skia's sk_sp smart pointers over the old raw pointer API.
Also take advantage of a few nearby sk_sp<SkImageFilter> opportunities.

R=fmalita@chromium.org,danakj@chromium.org
TBR=sky@chromium.org,junov@chromium.org
BUG=599466, skia:5077
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04
Cr-Commit-Position: refs/heads/master@{#384684}

[tomhudson, 2016-04-01 13:40:26]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_XFERMODE_PTR

Favor Skia's sk_sp smart pointers over the old raw pointer API.
Also take advantage of a few nearby sk_sp<SkImageFilter> opportunities.

R=fmalita@chromium.org,danakj@chromium.org
TBR=sky@chromium.org,junov@chromium.org
BUG=599466,skia:5077
==========

to

==========
Remove SK_SUPPORT_LEGACY_XFERMODE_PTR

Favor Skia's sk_sp smart pointers over the old raw pointer API.
Also take advantage of a few nearby sk_sp<SkImageFilter> opportunities.

R=fmalita@chromium.org,danakj@chromium.org
TBR=sky@chromium.org,junov@chromium.org
BUG=599466,skia:5077
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[tomhudson, 2016-04-01 13:42:17]

The CQ bit was checked by tomhudson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 13:42:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849213002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849213002/1

[commit-bot: I haz the power, 2016-04-01 15:57:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 15:57:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tomhudson, 2016-04-01 17:28:31]

Another smart pointer change with a fairly small footprint.

[f(malita), 2016-04-01 18:16:01]

LGTM % move tweaks.

https://codereview.chromium.org/1849213002/diff/20001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/1849213002/diff/20001/cc/output/gl_renderer.c...
cc/output/gl_renderer.cc:656: paint.setImageFilter(filter_with_local_scale);
std::move(filter_with_local_scale) or inline.

https://codereview.chromium.org/1849213002/diff/20001/cc/output/software_rend...
File cc/output/software_renderer.cc (right):

https://codereview.chromium.org/1849213002/diff/20001/cc/output/software_rend...
cc/output/software_renderer.cc:648: paint.setImageFilter(localIMF);
std::move or inline.

https://codereview.chromium.org/1849213002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
(right):

https://codereview.chromium.org/1849213002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp:927:
layerPaint.setImageFilter(localFilter);
std::move or inline.

https://codereview.chromium.org/1849213002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp (right):

https://codereview.chromium.org/1849213002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp:64: return
fromSkSp(SkXfermodeImageFilter::Make(mode, background.get(), foreground.get(),
&cropRect));
std::move(mode)

https://codereview.chromium.org/1849213002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp
(right):

https://codereview.chromium.org/1849213002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp:214: return
fromSkSp(SkXfermodeImageFilter::Make(mode, background.get(), foreground.get(),
&cropRect));
std::move(mode)

https://codereview.chromium.org/1849213002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
(right):

https://codereview.chromium.org/1849213002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp:223:
return fromSkSp(combineImageFilter);
std::move or inline.

https://codereview.chromium.org/1849213002/diff/20001/ui/views/controls/butto...
File ui/views/controls/button/label_button_border.cc (right):

https://codereview.chromium.org/1849213002/diff/20001/ui/views/controls/butto...
ui/views/controls/button/label_button_border.cc:151:
paint.setXfermode(sk_arith_xfer);
std::move or inline.

[tomhudson, 2016-04-01 18:35:31]

Ugh, yeah, too rushed of me. All done, preferring inlining.

[danakj, 2016-04-01 18:46:01]

cc LGTM

[tomhudson, 2016-04-01 18:51:24]

The CQ bit was checked by tomhudson@google.com

[tomhudson, 2016-04-01 18:51:24]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1849213002/#ps40001
(title: "move or inline per review")

[commit-bot: I haz the power, 2016-04-01 18:51:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849213002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849213002/40001

[sky, 2016-04-01 20:31:42]

LGTM

[commit-bot: I haz the power, 2016-04-01 20:46:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-01 20:48:22]

Description was changed from

==========
Remove SK_SUPPORT_LEGACY_XFERMODE_PTR

Favor Skia's sk_sp smart pointers over the old raw pointer API.
Also take advantage of a few nearby sk_sp<SkImageFilter> opportunities.

R=fmalita@chromium.org,danakj@chromium.org
TBR=sky@chromium.org,junov@chromium.org
BUG=599466,skia:5077
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove SK_SUPPORT_LEGACY_XFERMODE_PTR

Favor Skia's sk_sp smart pointers over the old raw pointer API.
Also take advantage of a few nearby sk_sp<SkImageFilter> opportunities.

R=fmalita@chromium.org,danakj@chromium.org
TBR=sky@chromium.org,junov@chromium.org
BUG=599466,skia:5077
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04
Cr-Commit-Position: refs/heads/master@{#384684}
==========

[commit-bot: I haz the power, 2016-04-01 20:48:24]

Patchset 3 (id:??) landed as
https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04
Cr-Commit-Position: refs/heads/master@{#384684}