third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp - Issue 1849213002: Remove SK_SUPPORT_LEGACY_XFERMODE_PTR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

Issue 1849213002: Remove SK_SUPPORT_LEGACY_XFERMODE_PTR (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move or inline per review Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

index 451ffed6946a1bc4c6f4166400f7c79a623b0bd9..92a2d15756a8a8573c87fac1982d735bce94718a 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp

@@ -59,9 +59,9 @@ PassRefPtr<SkImageFilter> FEBlend::createImageFilter(SkiaImageFilterBuilder& bui

{

RefPtr<SkImageFilter> foreground(builder.build(inputEffect(0), operatingColorSpace()));

RefPtr<SkImageFilter> background(builder.build(inputEffect(1), operatingColorSpace()));

- RefPtr<SkXfermode> mode(adoptRef(SkXfermode::Create(WebCoreCompositeToSkiaComposite(CompositeSourceOver, m_mode))));

+ sk_sp<SkXfermode> mode(SkXfermode::Make(WebCoreCompositeToSkiaComposite(CompositeSourceOver, m_mode)));

SkImageFilter::CropRect cropRect = getCropRect();

- return adoptRef(SkXfermodeImageFilter::Create(mode.get(), background.get(), foreground.get(), &cropRect));

+ return fromSkSp(SkXfermodeImageFilter::Make(std::move(mode), background.get(), foreground.get(), &cropRect));

}

TextStream& FEBlend::externalRepresentation(TextStream& ts, int indent) const