Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1849133006: Revert "ChromeOS: Add SystemTimezoneAutomaticDetection policy." (Closed)

Created:
4 years, 8 months ago by Alexander Alekseev
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, asvitkine+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, tnagel+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "ChromeOS: Add SystemTimezoneAutomaticDetection policy." This reverts commit fc3524a0efece0f2b55b08980b74c23be65ed8dd. Reason for revert: Broke "Closure Compilation Linux" bot. Original issue's description: > ChromeOS: Add SystemTimezoneAutomaticDetection policy. > > This CL adds SystemTimezoneAutomaticDetection device policy > and modifies all necessary components to support it. > > BUG=596690 > TEST=unittest,browsertest > > Review URL: https://codereview.chromium.org/1843523002 > > Cr-Commit-Position: refs/heads/master@{#384768} TBR=stevenjb@chromium.org,cschuet@chromium.org,bartfab@chromium.org,isherman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596690 Committed: https://chromium.googlesource.com/chromium/src/+/048b30171ae6db3249101801d814b8f7a4b21c53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -430 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/policy/proto/chrome_device_policy.proto View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 4 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/system/timezone_resolver_manager.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/system/timezone_resolver_manager.cc View 6 chunks +1 line, -59 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +0 lines, -150 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 4 chunks +6 lines, -50 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 3 chunks +0 lines, -24 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +0 lines, -8 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/policy/resources/policy_templates.json View 2 chunks +1 line, -55 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/048b30171ae6db3249101801d814b8f7a4b21c53 Cr-Commit-Position: refs/heads/master@{#384783}
4 years, 8 months ago (2016-04-02 01:56:16 UTC) #2
Alexander Alekseev
4 years, 8 months ago (2016-04-02 01:57:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
048b30171ae6db3249101801d814b8f7a4b21c53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698