ChromeOS: Add SystemTimezoneAutomaticDetection policy.

ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest

Committed: https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd
Cr-Commit-Position: refs/heads/master@{#384768}

Committed: https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3
Cr-Commit-Position: refs/heads/master@{#385157}

[Alexander Alekseev, 2016-03-29 03:22:05]

alemate@chromium.org changed reviewers:
+ stevenjb@chromium.org, tnagel@chromium.org

[Alexander Alekseev, 2016-03-29 03:22:06]

This is the second part of https://codereview.chromium.org/1836433003/

Please review:

tnagel@:
  *policy*

stevenjb@:
  all the rest ;)

[Alexander Alekseev, 2016-03-29 03:22:13]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 03:22:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843523002/1

[commit-bot: I haz the power, 2016-03-29 04:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 04:43:05]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-03-29 17:01:24]

https://codereview.chromium.org/1843523002/diff/1/chrome/browser/chromeos/pre...
File chrome/browser/chromeos/preferences.h (right):

https://codereview.chromium.org/1843523002/diff/1/chrome/browser/chromeos/pre...
chrome/browser/chromeos/preferences.h:50: };
Why not include the pb.h file directly where this is used? Keeping enums in sync
tends to lead to problems down the road.

https://codereview.chromium.org/1843523002/diff/1/chrome/browser/resources/op...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/1843523002/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/browser_options.js:1703:
$('resolve-timezone-by-geolocation').checked = null;
As discussed in the previous CL, 'false' can be used in JS and is consistent to
other options webui JS.

[Alexander Alekseev, 2016-03-30 03:07:23]

https://codereview.chromium.org/1843523002/diff/1/chrome/browser/chromeos/pre...
File chrome/browser/chromeos/preferences.h (right):

https://codereview.chromium.org/1843523002/diff/1/chrome/browser/chromeos/pre...
chrome/browser/chromeos/preferences.h:50: };
On 2016/03/29 17:01:24, stevenjb wrote:
> Why not include the pb.h file directly where this is used? Keeping enums in
sync
> tends to lead to problems down the road.
> 

Done.

https://codereview.chromium.org/1843523002/diff/1/chrome/browser/resources/op...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/1843523002/diff/1/chrome/browser/resources/op...
chrome/browser/resources/options/browser_options.js:1703:
$('resolve-timezone-by-geolocation').checked = null;
On 2016/03/29 17:01:24, stevenjb wrote:
> As discussed in the previous CL, 'false' can be used in JS and is consistent
to
> other options webui JS.

You're right.But I checked and it definitely did not before rebase. Probably
something was fixed in between.

[Alexander Alekseev, 2016-03-30 12:34:15]

alemate@chromium.org changed reviewers:
+ cschuet@chromium.org

[Alexander Alekseev, 2016-03-30 12:34:16]

-tnagel
+cschuet


Please review:

cschuet@:
  *policy*

[Alexander Alekseev, 2016-03-30 12:34:33]

Description was changed from

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest
==========

to

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest
==========

[Alexander Alekseev, 2016-03-30 12:34:33]

alemate@chromium.org changed reviewers:
- tnagel@chromium.org

[cschuet (SLOW), 2016-03-30 13:08:48]

https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc (right):

https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc:892: new
base::FundamentalValue(policy.system_timezone_automatic_detection()
Use DecodeIntegerValue() which performs range checks as well.

https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right):

https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:690: message
SystemTimezoneAutomaticDetectionProto {
Rather than creating a new submessage for just this policy stick it into the
existing SystemTimezoneProto message.

[Alexander Alekseev, 2016-03-31 06:51:50]

Please take a look at the policy test.

https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc (right):

https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc:892: new
base::FundamentalValue(policy.system_timezone_automatic_detection()
On 2016/03/30 13:08:48, cschuet (SLOW) wrote:
> Use DecodeIntegerValue() which performs range checks as well.

Done.

https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right):

https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:690: message
SystemTimezoneAutomaticDetectionProto {
On 2016/03/30 13:08:48, cschuet (SLOW) wrote:
> Rather than creating a new submessage for just this policy stick it into the
> existing SystemTimezoneProto message.

I will try, but this seems to be tricky.
SystemTimezone is not mapped to any Local State preference.
It was implemented before automatic mappings were implemented.
We also do not have any tests for SystemTimezone.

[Alexander Alekseev, 2016-03-31 08:10:37]

I moved the policy to SystemTimezone proto.

I could not invent correct data for the 'policy_templates.json' and
'policy_test_cases.json' .

cschuet@, could you help me with this data?

Also we now do not have UMA monitoring for this value.

cschuet@: could you suggest the way we could implement it?

I personally think that the previous patch set (see patch set 5) is much
simpler...

[cschuet (SLOW), 2016-03-31 08:14:50]

On 2016/03/31 06:51:50, Alexander Alekseev wrote:
> Please take a look at the policy test.
> 
>
https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
> File chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc (right):
> 
>
https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
> chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc:892: new
> base::FundamentalValue(policy.system_timezone_automatic_detection()
> On 2016/03/30 13:08:48, cschuet (SLOW) wrote:
> > Use DecodeIntegerValue() which performs range checks as well.
> 
> Done.
> 
>
https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
> File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right):
> 
>
https://codereview.chromium.org/1843523002/diff/60001/chrome/browser/chromeos...
> chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:690: message
> SystemTimezoneAutomaticDetectionProto {
> On 2016/03/30 13:08:48, cschuet (SLOW) wrote:
> > Rather than creating a new submessage for just this policy stick it into the
> > existing SystemTimezoneProto message.
> 
> I will try, but this seems to be tricky.
> SystemTimezone is not mapped to any Local State preference.
> It was implemented before automatic mappings were implemented.
> We also do not have any tests for SystemTimezone.

LGTM

[cschuet (SLOW), 2016-03-31 08:15:03]

https://codereview.chromium.org/1843523002/diff/100001/chrome/browser/policy/...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/1843523002/diff/100001/chrome/browser/policy/...
chrome/browser/policy/policy_browsertest.cc:4003: // const char kTestUser1Hash[]
= "test1@domain.com-hash";
remove commented code.

[cschuet (SLOW), 2016-03-31 08:54:25]

On 2016/03/31 08:15:03, cschuet (SLOW) wrote:
>
https://codereview.chromium.org/1843523002/diff/100001/chrome/browser/policy/...
> File chrome/browser/policy/policy_browsertest.cc (right):
> 
>
https://codereview.chromium.org/1843523002/diff/100001/chrome/browser/policy/...
> chrome/browser/policy/policy_browsertest.cc:4003: // const char
kTestUser1Hash[]
> = mailto:"test1@domain.com-hash";
> remove commented code.

Sorry, for the confusion: Your original implementation looked fine. I just
wanted you to move the enum policy you have defined into the same proto message
like the other system time related policy. Don't merge the policies in
policy_templates.json. Keep them separate. My comment was just about the way you
are encoding the policy in the proto.

not lgtm

[cschuet (SLOW), 2016-03-31 08:55:22]

https://codereview.chromium.org/1843523002/diff/100001/components/policy/reso...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1843523002/diff/100001/components/policy/reso...
components/policy/resources/policy_templates.json:5727: 'timezone': { 'type':
'main' },
This should be 'type': 'int-enum'.

[Alexander Alekseev, 2016-03-31 10:24:38]

> Sorry, for the confusion: Your original implementation looked fine. I just
> wanted you to move the enum policy you have defined into the same proto
message
> like the other system time related policy. Don't merge the policies in
> policy_templates.json. Keep them separate. My comment was just about the way
you
> are encoding the policy in the proto.

Did you mean something like this? When an entry in policy templates doesn't have
separate message? I didn't know we support this.

PTAL.

https://codereview.chromium.org/1843523002/diff/100001/chrome/browser/policy/...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/1843523002/diff/100001/chrome/browser/policy/...
chrome/browser/policy/policy_browsertest.cc:4003: // const char kTestUser1Hash[]
= "test1@domain.com-hash";
On 2016/03/31 08:15:02, cschuet (SLOW) wrote:
> remove commented code.

Done.

https://codereview.chromium.org/1843523002/diff/100001/components/policy/reso...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1843523002/diff/100001/components/policy/reso...
components/policy/resources/policy_templates.json:5727: 'timezone': { 'type':
'main' },
On 2016/03/31 08:55:21, cschuet (SLOW) wrote:
> This should be 'type': 'int-enum'.

I reverted this.

[Alexander Alekseev, 2016-03-31 10:24:57]

Description was changed from

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest
==========

to

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest
==========

[Alexander Alekseev, 2016-03-31 10:27:25]

alemate@chromium.org changed reviewers:
+ bartfab@chromium.org

[Alexander Alekseev, 2016-03-31 10:27:26]

+bartfab@ : for
  policy_templates.json (as owner)

Please review.

[cschuet (SLOW), 2016-03-31 11:58:11]

On 2016/03/31 10:24:38, Alexander Alekseev wrote:
> > Sorry, for the confusion: Your original implementation looked fine. I just
> > wanted you to move the enum policy you have defined into the same proto
> message
> > like the other system time related policy. Don't merge the policies in
> > policy_templates.json. Keep them separate. My comment was just about the way
> you
> > are encoding the policy in the proto.
> 
> Did you mean something like this? When an entry in policy templates doesn't
have
> separate message? I didn't know we support this.
> 
> PTAL.

This is exactly what I meant. I am not sure what you mean by "When an entry in
policy templates doesn't have separate message". policy_templates.json is
essentially a flat file. Granted it does support one level of grouping, but note
that this grouping is only cosmetic. It is only reflected in the visualization
of the generated .kml files and more importantly does not correspond to the
grouping in the .proto file. The automatic matching that exists for user
policies does not exist for device policies which you can see from the fact that
the device policy coder is handwritten.

For the .proto I believe this new policy belongs in the same proto submesage as
the other timezone related policies do, especially as there is an interaction
between them (as you have pointed out in the description). For
policy_templates.json, I think it should be a top level policy (just as the
other timezone policies). But I will also let bartfab@ chime in.

For me, this LGTM now.

> 
>
https://codereview.chromium.org/1843523002/diff/100001/chrome/browser/policy/...
> File chrome/browser/policy/policy_browsertest.cc (right):
> 
>
https://codereview.chromium.org/1843523002/diff/100001/chrome/browser/policy/...
> chrome/browser/policy/policy_browsertest.cc:4003: // const char
kTestUser1Hash[]
> = mailto:"test1@domain.com-hash";
> On 2016/03/31 08:15:02, cschuet (SLOW) wrote:
> > remove commented code.
> 
> Done.
> 
>
https://codereview.chromium.org/1843523002/diff/100001/components/policy/reso...
> File components/policy/resources/policy_templates.json (right):
> 
>
https://codereview.chromium.org/1843523002/diff/100001/components/policy/reso...
> components/policy/resources/policy_templates.json:5727: 'timezone': { 'type':
> 'main' },
> On 2016/03/31 08:55:21, cschuet (SLOW) wrote:
> > This should be 'type': 'int-enum'.
> 
> I reverted this.

[Alexander Alekseev, 2016-03-31 12:20:05]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 12:20:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843523002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843523002/120001

[commit-bot: I haz the power, 2016-03-31 12:22:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 12:22:50]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[stevenjb, 2016-03-31 16:12:04]

lgtm

https://codereview.chromium.org/1843523002/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc (right):

https://codereview.chromium.org/1843523002/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc:715:
key::kSystemTimezoneAutomaticDetection,
nit: move to prev line

[Alexander Alekseev, 2016-03-31 21:30:31]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 21:30:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843523002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843523002/120001

[Alexander Alekseev, 2016-03-31 21:34:28]

alemate@chromium.org changed reviewers:
+ isherman@chromium.org

[Alexander Alekseev, 2016-03-31 21:34:29]

+isherman@ for histograms.xml .

Please review.

https://codereview.chromium.org/1843523002/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc (right):

https://codereview.chromium.org/1843523002/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc:715:
key::kSystemTimezoneAutomaticDetection,
On 2016/03/31 16:12:03, stevenjb wrote:
> nit: move to prev line

Done.

[Ilya Sherman, 2016-04-01 07:08:27]

histograms.xml lgtm

[bartfab (slow), 2016-04-01 14:44:50]

policy_templates.json LGTM with nits.

https://codereview.chromium.org/1843523002/diff/140001/components/policy/reso...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1843523002/diff/140001/components/policy/reso...
components/policy/resources/policy_templates.json:8405: 'caption': '''Always
send WiFi acess-points to server.use fine-grained timezone detection (send
curently visible WiFi access points to Geolocation API to better locate
geographical position).''',
Nit 1: s/server.use/server and use/
Nit 2: These captions should be really, really short. Please putp lengthy
explanations in the policy 'desc' only.

https://codereview.chromium.org/1843523002/diff/140001/components/policy/reso...
components/policy/resources/policy_templates.json:8416: 'tags': [],
This should be tagged with "google-sharing" as
AUTOMATIC_TIMEZONE_DETECTION_SEND_WIFI_ACCESS_POINTS causes Chrome OS to send
the list of WiFi access points.

https://codereview.chromium.org/1843523002/diff/140001/components/policy/reso...
components/policy/resources/policy_templates.json:8421: If set to
AUTOMATIC_TIMEZONE_DETECTION_DISABLED, automatic timezone controls in
chrome://settings will be disabled. Automatic timezone detection will be always
off. Timezone could be controlled either by SystemTimezone policy or by timezone
selector in chrome://settings.
"Timezone could be controlled either by SystemTimezone" does not make sense here
- if SystemTimezone is set, this policy here is ignored, so its value is
irrelevant.

https://codereview.chromium.org/1843523002/diff/140001/components/policy/reso...
components/policy/resources/policy_templates.json:8429: If SystemTimezone policy
is set. it overrides this policy. In this case automatic timezone detection is
completely disabled.''',
Nit: s/set./set,/

[Alexander Alekseev, 2016-04-01 23:59:33]

I also replaced enum values in policy_templates with Camel case like this:
'AUTOMATIC_TIMEZONE_DETECTION_USERS_DECIDE' =>
'TimezoneAutomaticDetectionUsersDecide'. It looks like camel case is more often
used in policy_templates for enums.

Thank you all!  I'll commit this now.

https://codereview.chromium.org/1843523002/diff/140001/components/policy/reso...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1843523002/diff/140001/components/policy/reso...
components/policy/resources/policy_templates.json:8405: 'caption': '''Always
send WiFi acess-points to server.use fine-grained timezone detection (send
curently visible WiFi access points to Geolocation API to better locate
geographical position).''',
On 2016/04/01 14:44:50, bartfab (slow) wrote:
> Nit 1: s/server.use/server and use/
> Nit 2: These captions should be really, really short. Please putp lengthy
> explanations in the policy 'desc' only.

Done.

https://codereview.chromium.org/1843523002/diff/140001/components/policy/reso...
components/policy/resources/policy_templates.json:8416: 'tags': [],
On 2016/04/01 14:44:50, bartfab (slow) wrote:
> This should be tagged with "google-sharing" as
> AUTOMATIC_TIMEZONE_DETECTION_SEND_WIFI_ACCESS_POINTS causes Chrome OS to send
> the list of WiFi access points.

Done.

https://codereview.chromium.org/1843523002/diff/140001/components/policy/reso...
components/policy/resources/policy_templates.json:8421: If set to
AUTOMATIC_TIMEZONE_DETECTION_DISABLED, automatic timezone controls in
chrome://settings will be disabled. Automatic timezone detection will be always
off. Timezone could be controlled either by SystemTimezone policy or by timezone
selector in chrome://settings.
On 2016/04/01 14:44:50, bartfab (slow) wrote:
> "Timezone could be controlled either by SystemTimezone" does not make sense
here
> - if SystemTimezone is set, this policy here is ignored, so its value is
> irrelevant.

Done.

https://codereview.chromium.org/1843523002/diff/140001/components/policy/reso...
components/policy/resources/policy_templates.json:8429: If SystemTimezone policy
is set. it overrides this policy. In this case automatic timezone detection is
completely disabled.''',
On 2016/04/01 14:44:50, bartfab (slow) wrote:
> Nit: s/set./set,/

Done.

[Alexander Alekseev, 2016-04-01 23:59:47]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-04-01 23:59:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, cschuet@chromium.org, bartfab@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1843523002/#ps160001
(title: "Update after review.")

[commit-bot: I haz the power, 2016-04-02 00:00:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843523002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843523002/160001

[commit-bot: I haz the power, 2016-04-02 01:18:01]

Description was changed from

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest
==========

to

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest
==========

[commit-bot: I haz the power, 2016-04-02 01:18:03]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-04-02 01:19:37]

Description was changed from

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest
==========

to

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest

Committed: https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd
Cr-Commit-Position: refs/heads/master@{#384768}
==========

[commit-bot: I haz the power, 2016-04-02 01:19:38]

Patchset 9 (id:??) landed as
https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd
Cr-Commit-Position: refs/heads/master@{#384768}

[Dan Beam, 2016-04-02 01:39:13]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-04-02 01:39:14]

https://codereview.chromium.org/1843523002/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/1843523002/diff/160001/chrome/browser/resourc...
chrome/browser/resources/options/browser_options.js:128: * @private {boolean}
0 isn't a {boolean}

https://codereview.chromium.org/1843523002/diff/160001/chrome/browser/resourc...
chrome/browser/resources/options/browser_options.js:1706: 0 /* USERS_DECIDE */)
{
can you just put an @enum {number} into this script?

https://codereview.chromium.org/1843523002/diff/160001/chrome/browser/resourc...
chrome/browser/resources/options/browser_options.js:1744: *     managed by
enterprise policy. False otherwize.
missing @param for value

[Alexander Alekseev, 2016-04-02 01:55:58]

Description was changed from

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest

Committed: https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd
Cr-Commit-Position: refs/heads/master@{#384768}
==========

to

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest

Committed: https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd
Cr-Commit-Position: refs/heads/master@{#384768}
==========

[Dan Beam, 2016-04-05 07:01:50]

dbeam@chromium.org changed reviewers:
- dbeam@chromium.org

[Alexander Alekseev, 2016-04-05 07:27:55]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 07:28:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843523002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843523002/180001

[commit-bot: I haz the power, 2016-04-05 07:29:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 07:30:01]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Alexander Alekseev, 2016-04-05 08:03:38]

https://codereview.chromium.org/1843523002/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/options/browser_options.js (right):

https://codereview.chromium.org/1843523002/diff/160001/chrome/browser/resourc...
chrome/browser/resources/options/browser_options.js:128: * @private {boolean}
On 2016/04/02 01:39:14, Dan Beam wrote:
> 0 isn't a {boolean}

Done.

https://codereview.chromium.org/1843523002/diff/160001/chrome/browser/resourc...
chrome/browser/resources/options/browser_options.js:1706: 0 /* USERS_DECIDE */)
{
On 2016/04/02 01:39:14, Dan Beam wrote:
> can you just put an @enum {number} into this script?

Done.

https://codereview.chromium.org/1843523002/diff/160001/chrome/browser/resourc...
chrome/browser/resources/options/browser_options.js:1744: *     managed by
enterprise policy. False otherwize.
On 2016/04/02 01:39:14, Dan Beam wrote:
> missing @param for value

Done.

[Alexander Alekseev, 2016-04-05 08:25:51]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 08:26:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843523002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843523002/200001

[bartfab (slow), 2016-04-05 09:33:53]

Still LGTM

[commit-bot: I haz the power, 2016-04-05 09:35:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 09:35:25]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-04-05 12:15:59]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-04-05 12:15:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, isherman@chromium.org, cschuet@chromium.org
Link to the patchset: https://codereview.chromium.org/1843523002/#ps200001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-04-05 12:16:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843523002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843523002/200001

[commit-bot: I haz the power, 2016-04-05 12:21:45]

Description was changed from

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest

Committed: https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd
Cr-Commit-Position: refs/heads/master@{#384768}
==========

to

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest

Committed: https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd
Cr-Commit-Position: refs/heads/master@{#384768}
==========

[commit-bot: I haz the power, 2016-04-05 12:21:49]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-04-05 12:23:18]

Description was changed from

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest

Committed: https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd
Cr-Commit-Position: refs/heads/master@{#384768}
==========

to

==========
ChromeOS: Add SystemTimezoneAutomaticDetection policy.

This CL adds SystemTimezoneAutomaticDetection device policy
and modifies all necessary components to support it.

BUG=596690
TEST=unittest,browsertest

Committed: https://crrev.com/fc3524a0efece0f2b55b08980b74c23be65ed8dd
Cr-Commit-Position: refs/heads/master@{#384768}

Committed: https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3
Cr-Commit-Position: refs/heads/master@{#385157}
==========

[commit-bot: I haz the power, 2016-04-05 12:23:20]

Patchset 11 (id:??) landed as
https://crrev.com/d70e82f6d166b8f1548e127aaef2114d45a701e3
Cr-Commit-Position: refs/heads/master@{#385157}

[Andrew T Wilson (Slow), 2016-04-07 12:07:19]

atwilson@chromium.org changed reviewers:
+ atwilson@chromium.org

[Andrew T Wilson (Slow), 2016-04-07 12:07:20]

https://codereview.chromium.org/1843523002/diff/200001/components/policy/reso...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1843523002/diff/200001/components/policy/reso...
components/policy/resources/policy_templates.json:140: #   For your editing
convenience: highest ID currently used: 325
Please remember to update this ID in the future when adding a new policy.

[Alexander Alekseev, 2016-04-08 01:15:05]

https://codereview.chromium.org/1843523002/diff/200001/components/policy/reso...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/1843523002/diff/200001/components/policy/reso...
components/policy/resources/policy_templates.json:140: #   For your editing
convenience: highest ID currently used: 325
On 2016/04/07 12:07:20, Andrew T Wilson (Slow) wrote:
> Please remember to update this ID in the future when adding a new policy.

I am sorry, I missed this.