Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184903003: Window ownership -> WindowTreeHost (Closed)

Created:
6 years, 9 months ago by Ben Goodger (Google)
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+aura_chromium.org, tfarina, kalyank, sadrul, ben+views_chromium.org, ben+corewm_chromium.org
Visibility:
Public.

Description

Window ownership -> WindowTreeHost Replaces Window::GetDispatcher with Window::GetHost(). Had to clear ScreenPositionClient property prior to window teardown as tests on desktop delete it prior to destroying the window hierarchy. Unhooking the property appears to have no ill-effect. R=sky@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254642

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 1

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -520 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/key_hold_detector.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M ash/autoclick/autoclick_controller.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ash/debug.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ash/display/cursor_window_controller.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ash/display/display_controller.cc View 1 2 5 chunks +10 lines, -13 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 1 2 6 chunks +15 lines, -15 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 2 7 chunks +35 lines, -37 lines 0 comments Download
M ash/display/mirror_window_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mirror_window_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_position_controller.cc View 1 2 3 2 chunks +5 lines, -7 lines 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 2 3 chunks +14 lines, -12 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M ash/root_window_controller.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_watcher_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M ash/sticky_keys/sticky_keys_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/sticky_keys/sticky_keys_overlay_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/sticky_keys/sticky_keys_unittest.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/mirror_window_test_api.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/mirror_window_test_api.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M ash/test/ui_controls_factory_ash.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_interactive_uitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/caption_buttons/frame_maximize_button_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/lock_state_controller.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/screen_dimmer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 2 6 chunks +11 lines, -6 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/password_manager/password_manager_util_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_flash_drm_host.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/certificate_viewer_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/star_view_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_x11.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/interactive_test_utils_win.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_aura.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 6 27 chunks +55 lines, -57 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/aura/window_slider_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_download_manager_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_views.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/client/default_capture_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/remote_window_tree_host_win.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/test/event_generator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/ui_controls_factory_aurawin.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window.h View 1 2 4 chunks +6 lines, -9 lines 0 comments Download
M ui/aura/window.cc View 1 2 17 chunks +32 lines, -32 lines 0 comments Download
M ui/aura/window_event_dispatcher.h View 8 chunks +10 lines, -21 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 1 2 5 chunks +2 lines, -35 lines 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/window_targeter.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window_tree_host.h View 1 2 3 4 4 chunks +15 lines, -3 lines 0 comments Download
M ui/aura/window_tree_host.cc View 7 chunks +38 lines, -9 lines 0 comments Download
M ui/aura/window_tree_host_win.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/window_tree_host_x11.cc View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M ui/keyboard/keyboard_ui_handler.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/capture_controller.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/corewm/capture_controller_unittest.cc View 1 1 chunk +5 lines, -8 lines 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 2 3 4 5 3 chunks +5 lines, -3 lines 0 comments Download
M ui/views/corewm/input_method_event_filter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/corewm/input_method_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/event_utils_aura.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/test/ui_controls_factory_desktop_aurax11.cc View 1 2 3 5 chunks +19 lines, -21 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_capture_client.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drop_target_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.cc View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_win.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 2 3 chunks +12 lines, -16 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 3 3 chunks +9 lines, -11 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/tooltip_manager_aura.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/win/hwnd_util_aurawin.cc View 1 2 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
6 years, 9 months ago (2014-03-04 00:18:07 UTC) #1
sky
LGTM https://codereview.chromium.org/184903003/diff/60001/ui/aura/window_tree_host.h File ui/aura/window_tree_host.h (right): https://codereview.chromium.org/184903003/diff/60001/ui/aura/window_tree_host.h#newcode200 ui/aura/window_tree_host.h:200: Window* window_; // Owning. Can you document why ...
6 years, 9 months ago (2014-03-04 00:25:48 UTC) #2
Ben Goodger (Google)
6 years, 9 months ago (2014-03-04 03:42:50 UTC) #3
Message was sent while issue was closed. 
Committed patchset #7 manually as r254642 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698