content/browser/frame_host/render_frame_host_impl.h - Issue 1849013004: Fix JavaScript alerts from frames with oopif on, after a cross-process click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1849013004: Fix JavaScript alerts from frames with oopif on, after a cross-process click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@alertfix

Patch Set: cleaner re swapped out Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index acef076ae2f1c4b7bc2b61fd40f5fc29ce772670..6f5e3bf1b22ff643991aab3dbcb3ea3138f2094c 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -559,6 +559,12 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost,

// in a non-loading state.

void ResetLoadingState();

+ // Tells the renderer that this RenderFrame will soon be swapped out, and thus

+ // not to create any new modal dialogs until it happens. This must be done

+ // separately so that the PageGroupLoadDeferrers of any current dialogs are no

Charlie Reis 2016/04/08 17:27:39 nit: ScopedPageLoadDeferrer (throughout the CL)

Avi (use Gerrit) 2016/04/08 17:44:01 Done.

+ // longer on the stack when we attempt to swap it out.

+ void SuppressFurtherDialogs();

// PlzNavigate: returns the LoFi state of the last successful navigation that

// made a network request.

LoFiState last_navigation_lofi_state() const {

« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/web_contents/web_contents_impl_browsertest.cc » ('J')