content/browser/frame_host/render_frame_host_impl.cc - Issue 1849013004: Fix JavaScript alerts from frames with oopif on, after a cross-process click.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1849013004: Fix JavaScript alerts from frames with oopif on, after a cross-process click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@alertfix

Patch Set: cleaner re swapped out Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.h ('K') | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | content/browser/web_contents/web_contents_impl_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 61a342837e38f536692c14c9c8b92534e6f024fb..8c1a58d801a4ab1b09c3feb2ddd5b2bb3384109d 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -2396,6 +2396,10 @@ void RenderFrameHostImpl::ResetLoadingState() {

}

+void RenderFrameHostImpl::SuppressFurtherDialogs() {

+ Send(new FrameMsg_SuppressFurtherDialogs(GetRoutingID()));

bool RenderFrameHostImpl::IsSameSiteInstance(

RenderFrameHostImpl* other_render_frame_host) {

// As a sanity check, make sure the frame belongs to the same BrowserContext.