content/renderer/media/media_stream_constraints_util.cc - Issue 1849003002: Add video frame refresh to MediaStream and VideoCapture stacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_constraints_util.cc

Issue 1849003002: Add video frame refresh to MediaStream and VideoCapture stacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nick's PS3 comments (moving non-observer impl out of MSVideoSink interface). Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/media_stream_constraints_util.h ('k') | content/renderer/media/media_stream_video_capturer_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_constraints_util.cc

diff --git a/content/renderer/media/media_stream_constraints_util.cc b/content/renderer/media/media_stream_constraints_util.cc

index 1884f7547e8e7036576ddab676ae379d8f9d0ae6..d313f3b94247917806310927d7f0499a5c0d2e7c 100644

--- a/content/renderer/media/media_stream_constraints_util.cc

+++ b/content/renderer/media/media_stream_constraints_util.cc

@@ -107,11 +107,18 @@ bool GetConstraintValueAsDouble(

return ScanConstraintsForExactValue(constraints, picker, value);

}

+bool GetConstraintMinAsDouble(

+ const blink::WebMediaConstraints& constraints,

+ const blink::DoubleConstraint blink::WebMediaTrackConstraintSet::*picker,

+ double* value) {

+ return ScanConstraintsForMinValue(constraints, picker, value);

bool GetConstraintMaxAsDouble(

const blink::WebMediaConstraints& constraints,

const blink::DoubleConstraint blink::WebMediaTrackConstraintSet::*picker,

double* value) {

- return ScanConstraintsForExactValue(constraints, picker, value);

+ return ScanConstraintsForMaxValue(constraints, picker, value);

}

bool GetConstraintValueAsString(