Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: content/renderer/media/media_stream_constraints_util.cc

Issue 1849003002: Add video frame refresh to MediaStream and VideoCapture stacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nick's PS3 comments (moving non-observer impl out of MSVideoSink interface). Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/media_stream_constraints_util.h" 5 #include "content/renderer/media/media_stream_constraints_util.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "third_party/WebKit/public/platform/WebMediaConstraints.h" 9 #include "third_party/WebKit/public/platform/WebMediaConstraints.h"
10 #include "third_party/WebKit/public/platform/WebString.h" 10 #include "third_party/WebKit/public/platform/WebString.h"
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 return ScanConstraintsForMaxValue(constraints, picker, value); 100 return ScanConstraintsForMaxValue(constraints, picker, value);
101 } 101 }
102 102
103 bool GetConstraintValueAsDouble( 103 bool GetConstraintValueAsDouble(
104 const blink::WebMediaConstraints& constraints, 104 const blink::WebMediaConstraints& constraints,
105 const blink::DoubleConstraint blink::WebMediaTrackConstraintSet::*picker, 105 const blink::DoubleConstraint blink::WebMediaTrackConstraintSet::*picker,
106 double* value) { 106 double* value) {
107 return ScanConstraintsForExactValue(constraints, picker, value); 107 return ScanConstraintsForExactValue(constraints, picker, value);
108 } 108 }
109 109
110 bool GetConstraintMinAsDouble(
111 const blink::WebMediaConstraints& constraints,
112 const blink::DoubleConstraint blink::WebMediaTrackConstraintSet::*picker,
113 double* value) {
114 return ScanConstraintsForMinValue(constraints, picker, value);
115 }
116
110 bool GetConstraintMaxAsDouble( 117 bool GetConstraintMaxAsDouble(
111 const blink::WebMediaConstraints& constraints, 118 const blink::WebMediaConstraints& constraints,
112 const blink::DoubleConstraint blink::WebMediaTrackConstraintSet::*picker, 119 const blink::DoubleConstraint blink::WebMediaTrackConstraintSet::*picker,
113 double* value) { 120 double* value) {
114 return ScanConstraintsForExactValue(constraints, picker, value); 121 return ScanConstraintsForMaxValue(constraints, picker, value);
115 } 122 }
116 123
117 bool GetConstraintValueAsString( 124 bool GetConstraintValueAsString(
118 const blink::WebMediaConstraints& constraints, 125 const blink::WebMediaConstraints& constraints,
119 const blink::StringConstraint blink::WebMediaTrackConstraintSet::*picker, 126 const blink::StringConstraint blink::WebMediaTrackConstraintSet::*picker,
120 std::string* value) { 127 std::string* value) {
121 blink::WebVector<blink::WebString> return_value; 128 blink::WebVector<blink::WebString> return_value;
122 if (ScanConstraintsForExactValue(constraints, picker, &return_value)) { 129 if (ScanConstraintsForExactValue(constraints, picker, &return_value)) {
123 *value = return_value[0].utf8(); 130 *value = return_value[0].utf8();
124 return true; 131 return true;
125 } 132 }
126 return false; 133 return false;
127 } 134 }
128 135
129 rtc::Optional<bool> ConstraintToOptional( 136 rtc::Optional<bool> ConstraintToOptional(
130 const blink::WebMediaConstraints& constraints, 137 const blink::WebMediaConstraints& constraints,
131 const blink::BooleanConstraint blink::WebMediaTrackConstraintSet::*picker) { 138 const blink::BooleanConstraint blink::WebMediaTrackConstraintSet::*picker) {
132 bool value; 139 bool value;
133 if (GetConstraintValueAsBoolean(constraints, picker, &value)) { 140 if (GetConstraintValueAsBoolean(constraints, picker, &value)) {
134 return rtc::Optional<bool>(value); 141 return rtc::Optional<bool>(value);
135 } 142 }
136 return rtc::Optional<bool>(); 143 return rtc::Optional<bool>();
137 } 144 }
138 145
139 } // namespace content 146 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/media/media_stream_constraints_util.h ('k') | content/renderer/media/media_stream_video_capturer_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698