components/sync_driver/data_type_controller.h - Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/data_type_controller.h

Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from Sky and Max. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/backend_data_type_configurer.h ('k') | components/sync_driver/data_type_manager_impl.h » ('j') | components/sync_driver/data_type_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/data_type_controller.h

diff --git a/components/sync_driver/data_type_controller.h b/components/sync_driver/data_type_controller.h

index 0c1a61d22a6619621cf5a59cfb4f55c2106a594c..8f369f5508333d243ca28d0f5e067ec9409d0b2a 100644

--- a/components/sync_driver/data_type_controller.h

+++ b/components/sync_driver/data_type_controller.h

@@ -98,6 +98,10 @@ class DataTypeController

// the models are ready.

virtual void LoadModels(const ModelLoadCallback& model_load_callback) = 0;

+ // Registers with sync backend if needed. This function is called by

Nicolas Zea 2016/04/04 20:25:42 nit: explain why you would call this?

pavely 2016/04/05 18:21:52 Done.

+ // DataTypeManager before downloading initial data.

+ virtual void RegisterWithBackend(BackendDataTypeConfigurer* configurer) = 0;

// Will start a potentially asynchronous operation to perform the

// model association. Once the model association is done the callback will

// be invoked.