components/sync_driver/backend_data_type_configurer.h - Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/backend_data_type_configurer.h

Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from Sky and Max. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/browser_sync/browser/profile_sync_service.h ('k') | components/sync_driver/data_type_controller.h » ('j') | components/sync_driver/data_type_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/backend_data_type_configurer.h

diff --git a/components/sync_driver/backend_data_type_configurer.h b/components/sync_driver/backend_data_type_configurer.h

index 77ca6150af1f1a6bc678922fe815f243c764b796..6b541d6947e38041174c71617e718a6ddafddc5a 100644

--- a/components/sync_driver/backend_data_type_configurer.h

+++ b/components/sync_driver/backend_data_type_configurer.h

@@ -77,7 +77,7 @@ class BackendDataTypeConfigurer {

virtual void DeactivateDirectoryDataType(syncer::ModelType type) = 0;

// Activates change processing for the given non-blocking data type.

- // This must be called synchronously with the data type's model association.

+ // This must be called before initial sync for data type.

virtual void ActivateNonBlockingDataType(

syncer::ModelType type,

scoped_ptr<syncer_v2::ActivationContext> activation_context) = 0;