Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1848793003: Revert of 🍮 GN: Allow android lint to fail builds (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🍮 GN: Allow android lint to fail builds (patchset #1 id:1 of https://codereview.chromium.org/1848713002/ ) Reason for revert: Some warnings actually do exist, but bots didn't catch it because lint wasn't being re-run. Original issue's description: > GN: Allow android lint to fail builds > > This was enabled for GYP in June, but got missed for GN > > https://codereview.chromium.org/1190103002 > > BUG=none > > Committed: https://crrev.com/6c2b9752863847c6d1c4db39e5531fe335349afe > Cr-Commit-Position: refs/heads/master@{#384290} TBR=yfriedman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/d3ec1468d934cae4e83a3324f8172b0d5339c590 Cr-Commit-Position: refs/heads/master@{#384318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/config/android/internal_rules.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
agrieve
Created Revert of 🍮 GN: Allow android lint to fail builds
4 years, 8 months ago (2016-03-31 17:29:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848793003/1
4 years, 8 months ago (2016-03-31 17:30:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 17:31:04 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 17:32:42 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3ec1468d934cae4e83a3324f8172b0d5339c590
Cr-Commit-Position: refs/heads/master@{#384318}

Powered by Google App Engine
This is Rietveld 408576698