Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1848783003: [turbofan] Frame deconstruction self-validation. (Closed)

Created:
4 years, 8 months ago by Mircea Trofin
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Frame deconstruction self-validation. BUG= Committed: https://crrev.com/da97b701add1db601f74d5b5df9a456eec3174d4 Cr-Commit-Position: refs/heads/master@{#35178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mircea Trofin
This explains why things were working with frame elision before https://codereview.chromium.org/1847073002/ (+some luck)
4 years, 8 months ago (2016-03-31 17:35:58 UTC) #3
Benedikt Meurer
LGTM.
4 years, 8 months ago (2016-03-31 17:55:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848783003/1
4 years, 8 months ago (2016-03-31 17:57:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 18:40:36 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 18:42:55 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/da97b701add1db601f74d5b5df9a456eec3174d4
Cr-Commit-Position: refs/heads/master@{#35178}

Powered by Google App Engine
This is Rietveld 408576698