Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: src/compiler/code-generator.cc

Issue 1848783003: [turbofan] Frame deconstruction self-validation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/code-generator.cc
diff --git a/src/compiler/code-generator.cc b/src/compiler/code-generator.cc
index 08a7d2ef081eddad742fda6a2874b9b45a30e051..086da560e4fcd80ecf3a322f987c85ecc82df132 100644
--- a/src/compiler/code-generator.cc
+++ b/src/compiler/code-generator.cc
@@ -312,6 +312,10 @@ void CodeGenerator::AssembleBlock(const InstructionBlock* block) {
void CodeGenerator::AssembleInstruction(Instruction* instr,
const InstructionBlock* block) {
AssembleGaps(instr);
+ DCHECK_IMPLIES(
+ block->must_deconstruct_frame(),
+ instr != code()->InstructionAt(block->last_instruction_index()) ||
+ instr->IsRet() || instr->IsJump());
if (instr->IsJump() && block->must_deconstruct_frame()) {
AssembleDeconstructFrame();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698