Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1681)

Unified Diff: content/public/browser/resource_request_info.h

Issue 184873004: Update resource requests to remove redundant frame ID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Strengthen checks Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/resource_request_details.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/resource_request_info.h
diff --git a/content/public/browser/resource_request_info.h b/content/public/browser/resource_request_info.h
index 99ab6259e9e11a452de6b0fd346c14f8e0988b25..a448a3bc0bf2d9f04abbe05ae5a0f4fee7cef376 100644
--- a/content/public/browser/resource_request_info.h
+++ b/content/public/browser/resource_request_info.h
@@ -74,15 +74,12 @@ class ResourceRequestInfo {
// True if GetFrameID() represents a main frame in the RenderView.
battre 2014/03/03 11:35:28 This comment needs to be updated.
Charlie Reis 2014/03/03 17:14:44 Good catch. Fixing now.
Charlie Reis 2014/03/03 17:21:25 Done.
virtual bool IsMainFrame() const = 0;
- // Frame ID that sent this resource request. -1 if unknown / invalid.
- virtual int64 GetFrameID() const = 0;
-
// True if GetParentFrameID() represents a main frame in the RenderView.
virtual bool ParentIsMainFrame() const = 0;
battre 2014/03/03 11:35:28 This comment and function need to be updated.
Charlie Reis 2014/03/03 17:14:44 I'll update the comment to say GetParentRenderFram
Charlie Reis 2014/03/03 17:21:25 Done.
- // Frame ID of parent frame of frame that sent this resource request.
+ // Routing ID of parent frame of frame that sent this resource request.
// -1 if unknown / invalid.
- virtual int64 GetParentFrameID() const = 0;
+ virtual int GetParentRenderFrameID() const = 0;
// Returns the associated resource type.
virtual ResourceType::Type GetResourceType() const = 0;
« no previous file with comments | « content/public/browser/resource_request_details.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698