Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: content/public/browser/resource_request_info.h

Issue 184873004: Update resource requests to remove redundant frame ID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Strengthen checks Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_
6 #define CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_ 6 #define CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 #include "content/public/common/page_transition_types.h" 10 #include "content/public/common/page_transition_types.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 // Unique identifier (within the scope of the child process) for this request. 65 // Unique identifier (within the scope of the child process) for this request.
66 virtual int GetRequestID() const = 0; 66 virtual int GetRequestID() const = 0;
67 67
68 // The IPC route identifier of the RenderFrame. 68 // The IPC route identifier of the RenderFrame.
69 // TODO(jam): once all navigation and resource requests are sent between 69 // TODO(jam): once all navigation and resource requests are sent between
70 // frames and RenderView/RenderViewHost aren't involved we can remove this and 70 // frames and RenderView/RenderViewHost aren't involved we can remove this and
71 // just use GetRouteID above. 71 // just use GetRouteID above.
72 virtual int GetRenderFrameID() const = 0; 72 virtual int GetRenderFrameID() const = 0;
73 73
74 // True if GetFrameID() represents a main frame in the RenderView. 74 // True if GetFrameID() represents a main frame in the RenderView.
battre 2014/03/03 11:35:28 This comment needs to be updated.
Charlie Reis 2014/03/03 17:14:44 Good catch. Fixing now.
Charlie Reis 2014/03/03 17:21:25 Done.
75 virtual bool IsMainFrame() const = 0; 75 virtual bool IsMainFrame() const = 0;
76 76
77 // Frame ID that sent this resource request. -1 if unknown / invalid.
78 virtual int64 GetFrameID() const = 0;
79
80 // True if GetParentFrameID() represents a main frame in the RenderView. 77 // True if GetParentFrameID() represents a main frame in the RenderView.
81 virtual bool ParentIsMainFrame() const = 0; 78 virtual bool ParentIsMainFrame() const = 0;
battre 2014/03/03 11:35:28 This comment and function need to be updated.
Charlie Reis 2014/03/03 17:14:44 I'll update the comment to say GetParentRenderFram
Charlie Reis 2014/03/03 17:21:25 Done.
82 79
83 // Frame ID of parent frame of frame that sent this resource request. 80 // Routing ID of parent frame of frame that sent this resource request.
84 // -1 if unknown / invalid. 81 // -1 if unknown / invalid.
85 virtual int64 GetParentFrameID() const = 0; 82 virtual int GetParentRenderFrameID() const = 0;
86 83
87 // Returns the associated resource type. 84 // Returns the associated resource type.
88 virtual ResourceType::Type GetResourceType() const = 0; 85 virtual ResourceType::Type GetResourceType() const = 0;
89 86
90 // Returns the process type that initiated this request. 87 // Returns the process type that initiated this request.
91 virtual int GetProcessType() const = 0; 88 virtual int GetProcessType() const = 0;
92 89
93 // Returns the associated referrer policy. 90 // Returns the associated referrer policy.
94 virtual blink::WebReferrerPolicy GetReferrerPolicy() const = 0; 91 virtual blink::WebReferrerPolicy GetReferrerPolicy() const = 0;
95 92
(...skipping 22 matching lines...) Expand all
118 // Whether this is a download. 115 // Whether this is a download.
119 virtual bool IsDownload() const = 0; 116 virtual bool IsDownload() const = 0;
120 117
121 protected: 118 protected:
122 virtual ~ResourceRequestInfo() {} 119 virtual ~ResourceRequestInfo() {}
123 }; 120 };
124 121
125 } // namespace content 122 } // namespace content
126 123
127 #endif // CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_ 124 #endif // CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_INFO_H_
OLDNEW
« no previous file with comments | « content/public/browser/resource_request_details.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698