Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Issue 1848713002: 🍮 GN: Allow android lint to fail builds (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Allow android lint to fail builds This was enabled for GYP in June, but got missed for GN https://codereview.chromium.org/1190103002 BUG=none Committed: https://crrev.com/6c2b9752863847c6d1c4db39e5531fe335349afe Cr-Commit-Position: refs/heads/master@{#384290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848713002/1
4 years, 8 months ago (2016-03-31 03:04:40 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/151283)
4 years, 8 months ago (2016-03-31 03:45:28 UTC) #4
agrieve
On 2016/03/31 03:45:28, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 8 months ago (2016-03-31 13:54:40 UTC) #7
Yaron
lgtm
4 years, 8 months ago (2016-03-31 13:55:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848713002/1
4 years, 8 months ago (2016-03-31 15:34:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 15:52:13 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6c2b9752863847c6d1c4db39e5531fe335349afe Cr-Commit-Position: refs/heads/master@{#384290}
4 years, 8 months ago (2016-03-31 15:54:42 UTC) #14
agrieve
4 years, 8 months ago (2016-03-31 17:29:57 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1848793003/ by agrieve@chromium.org.

The reason for reverting is: Some warnings actually do exist, but bots didn't
catch it because lint wasn't being re-run..

Powered by Google App Engine
This is Rietveld 408576698