[gn] Move build to gypfiles

[gn] Move build to gypfiles

This prepares for pulling chromium's build as dependency for
gn. After this, the files in build and gypfiles need to stay
in sync until chromium is updated.

BUG=chromium:474921
LOG=n

Committed: https://crrev.com/3bf44848c3043eba6d32ba948ca25d4181611c32
Cr-Commit-Position: refs/heads/master@{#35898}

[Michael Achenbach, 2016-03-31 11:17:41]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 11:17:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848553003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848553003/20001

[commit-bot: I haz the power, 2016-03-31 11:19:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 11:19:15]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/3613)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/16034)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/3626)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/3626)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/17756)

[Michael Achenbach, 2016-03-31 12:40:05]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 12:40:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848553003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848553003/40001

[commit-bot: I haz the power, 2016-03-31 12:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 12:41:48]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/3619)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/16040)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/3632)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/3632)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/17762)

[Michael Achenbach, 2016-04-25 13:20:56]

Description was changed from

==========
[gn] Move build to build_v8

BUG=
==========

to

==========
(WIP) [gn] Move build to build_v8

BUG=
==========

[Michael Achenbach, 2016-04-25 13:21:18]

Description was changed from

==========
(WIP) [gn] Move build to build_v8

BUG=
==========

to

==========
(WIP) [gn] Move build to build_v8

BUG=chromium:474921
LOG=n
==========

[Michael Achenbach, 2016-04-27 14:39:46]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 14:39:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848553003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848553003/120001

[commit-bot: I haz the power, 2016-04-27 14:40:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 14:41:00]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/814)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14231)

[Michael Achenbach, 2016-04-27 15:17:04]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 15:17:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848553003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848553003/140001

[commit-bot: I haz the power, 2016-04-27 15:18:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 15:18:44]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/4932)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/816)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14234)

[Michael Achenbach, 2016-04-27 15:32:40]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 15:32:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848553003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848553003/160001

[commit-bot: I haz the power, 2016-04-27 15:36:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 15:36:43]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14237)

[Michael Achenbach, 2016-04-27 19:23:46]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-27 19:23:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848553003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848553003/200001

[Michael Achenbach, 2016-04-27 19:24:05]

Description was changed from

==========
(WIP) [gn] Move build to build_v8

BUG=chromium:474921
LOG=n
==========

to

==========
(WIP) [gn] Move build to gypfiles

BUG=chromium:474921
LOG=n
==========

[commit-bot: I haz the power, 2016-04-27 19:53:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 19:53:11]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-04-27 20:10:24]

machenbach@chromium.org changed reviewers:
+ jkummerow@chromium.org, jochen@chromium.org

[Michael Achenbach, 2016-04-27 20:10:26]

PTAL (preliminary).

The latest patch is something that works in v8 stand-alone. After this, I'll
upload one more patchset that keeps everything in "build" for compatibility.

The dance would be:
1) Land this and roll it into chromium
2) Update references in chromium and pdfium
3) Remove the contents in build (except the shim_headers script) and roll into
chromium

4) Manually land a CL that removes the shim_headers script (needed by ICU and
expected to be in build) and depses in build from chromium. Needs to be manually
as trybots don't work, they apply deps changes first, then gclient sync, then
apply the rest of the patch.

I assume when 1) rolls into chromium, it might lead to a bunch of compilation
warnings again like http://crbug.com/606547, so the idea would be to get 1 + 2
quickly done with a hackathon, before people get uneasy.

There is also the unresolved http://crbug.com/606898 and this CL might not make
things better.

If this is too huge to be done at once, we could also move it file by file and
dance a bit longer...

[Michael Achenbach, 2016-04-27 20:11:26]

Description was changed from

==========
(WIP) [gn] Move build to gypfiles

BUG=chromium:474921
LOG=n
==========

to

==========
(WIP) [gn] Move build to gypfiles

This prepares for pulling chromium's build as dependency for
gn.

BUG=chromium:474921
LOG=n
==========

[jochen (gone - plz use gerrit), 2016-04-27 20:14:41]

lgtm

[Nico, 2016-04-27 20:23:08]

1. Before doing another of these moves, it'd be good to finish fixing
regressions from the last one (https://crbug.com/606898)
2. It'd be good to not have another batch of these duplicate messages. (If
things go well, those will be errors instead of warnings in a few hours anyhoo).
If this would happen again, an we add something to gyp to dedupe them?

[Michael Achenbach, 2016-04-27 20:34:07]

On 2016/04/27 20:23:08, Nico wrote:
> 1. Before doing another of these moves, it'd be good to finish fixing
> regressions from the last one (https://crbug.com/606898)

Working on it. Help welcome.

> 2. It'd be good to not have another batch of these duplicate messages. (If
> things go well, those will be errors instead of warnings in a few hours
anyhoo).
> If this would happen again, an we add something to gyp to dedupe them?

Maybe this time we'll not run into this problem at all as I move only gypi files
which don't contain targets (didn't check that too closely yet though).
Otherwise, we could duplicate the targets used by chromium and by v8 stand-alone
(very tedious though). Otherwise I don't see a simple solution.

I'll try applying this in a local chromium checkout first and run gyp there to
see where we stand.

[brettw, 2016-04-27 20:37:19]

I've not been following what's happening. If you need anything from me please
let me know (and give more background).

[Michael Achenbach, 2016-04-27 21:05:15]

On 2016/04/27 20:37:19, brettw wrote:
> I've not been following what's happening. If you need anything from me please
> let me know (and give more background).

Was just FYI.

[Michael Achenbach, 2016-04-29 08:34:59]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 08:35:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848553003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848553003/220001

[Michael Achenbach, 2016-04-29 08:50:07]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-29 08:50:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848553003/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848553003/240001

[Michael Achenbach, 2016-04-29 08:51:47]

Description was changed from

==========
(WIP) [gn] Move build to gypfiles

This prepares for pulling chromium's build as dependency for
gn.

BUG=chromium:474921
LOG=n
==========

to

==========
[gn] Move build to gypfiles

This prepares for pulling chromium's build as dependency for
gn. After this, the files in build and gypfiles need to stay
in sync until chromium is updated.

BUG=chromium:474921
LOG=n
==========

[Michael Achenbach, 2016-04-29 08:52:51]

PTAL. Ready to land. Patch 12 shows that things work with the files moved, patch
13 keeps features.gypi and toolchain.gypi for compatibility. Will remove after
the chromium dance.

[commit-bot: I haz the power, 2016-04-29 09:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 09:13:59]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-04-29 09:19:07]

Some searching shows me that there isn't even a dance with chromium required.
toolchain.gypi and features.gypi are referenced only through v8.gyp. I'll keep
it this way anyway (defensive) - and delete the files in a separate CL.

[jochen (gone - plz use gerrit), 2016-04-29 09:50:19]

lgtm

[Michael Achenbach, 2016-04-29 10:06:05]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-04-29 10:06:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848553003/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848553003/240001

[commit-bot: I haz the power, 2016-04-29 10:09:00]

Description was changed from

==========
[gn] Move build to gypfiles

This prepares for pulling chromium's build as dependency for
gn. After this, the files in build and gypfiles need to stay
in sync until chromium is updated.

BUG=chromium:474921
LOG=n
==========

to

==========
[gn] Move build to gypfiles

This prepares for pulling chromium's build as dependency for
gn. After this, the files in build and gypfiles need to stay
in sync until chromium is updated.

BUG=chromium:474921
LOG=n
==========

[commit-bot: I haz the power, 2016-04-29 10:09:01]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-05-01 22:03:32]

Description was changed from

==========
[gn] Move build to gypfiles

This prepares for pulling chromium's build as dependency for
gn. After this, the files in build and gypfiles need to stay
in sync until chromium is updated.

BUG=chromium:474921
LOG=n
==========

to

==========
[gn] Move build to gypfiles

This prepares for pulling chromium's build as dependency for
gn. After this, the files in build and gypfiles need to stay
in sync until chromium is updated.

BUG=chromium:474921
LOG=n

Committed: https://crrev.com/3bf44848c3043eba6d32ba948ca25d4181611c32
Cr-Commit-Position: refs/heads/master@{#35898}
==========

[commit-bot: I haz the power, 2016-05-01 22:03:34]

Patchset 13 (id:??) landed as
https://crrev.com/3bf44848c3043eba6d32ba948ca25d4181611c32
Cr-Commit-Position: refs/heads/master@{#35898}