gypfiles/coverage_wrapper.py - Issue 1848553003: [gn] Move build to gypfiles

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gypfiles/coverage_wrapper.py

Issue 1848553003: [gn] Move build to gypfiles (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Preserve old state for the dance Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « gypfiles/config/win/msvs_dependencies.isolate ('k') | gypfiles/detect_v8_host_arch.py » ('j') | no next file with comments »

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2 # Copyright 2016 the V8 project authors. All rights reserved.	2 # Copyright 2016 the V8 project authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 # CC/CXX wrapper script that excludes certain file patterns from coverage	6 # CC/CXX wrapper script that excludes certain file patterns from coverage

7 # instrumentation.	7 # instrumentation.

8	8

9 import re	9 import re

10 import subprocess	10 import subprocess

(...skipping 16 matching lines...) Expand all Loading...
27 for exclusion in exclusions:	27 for exclusion in exclusions:

28 if re.search(r'\-o obj/%s[^ ]*\.o' % exclusion, text):	28 if re.search(r'\-o obj/%s[^ ]*\.o' % exclusion, text):

29 remove_if_exists(args, '-fprofile-arcs')	29 remove_if_exists(args, '-fprofile-arcs')

30 remove_if_exists(args, '-ftest-coverage')	30 remove_if_exists(args, '-ftest-coverage')

31 remove_if_exists(args, '-fsanitize-coverage=func')	31 remove_if_exists(args, '-fsanitize-coverage=func')

32 remove_if_exists(args, '-fsanitize-coverage=bb')	32 remove_if_exists(args, '-fsanitize-coverage=bb')

33 remove_if_exists(args, '-fsanitize-coverage=edge')	33 remove_if_exists(args, '-fsanitize-coverage=edge')

34 break	34 break

35	35

36 sys.exit(subprocess.check_call(args))	36 sys.exit(subprocess.check_call(args))

OLD	NEW