Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 1848533006: S390: Guard RISBG usage with facility check (Closed)

Created:
4 years, 8 months ago by JoranSiu
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Guard RISBG usage with facility check A use of risbg instruction is not guarded by the corresponding GENERAL_INSTR_EXT facility check. This will result in an illegal instruction when running on hardware without that facility installed (i.e. z9). R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Committed: https://crrev.com/c279138010961ef4040c8bfce790b8e1298cdfbc Cr-Commit-Position: refs/heads/master@{#35206}

Patch Set 1 #

Patch Set 2 : Fix typo with boolean operation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848533006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848533006/20001
4 years, 8 months ago (2016-03-31 22:08:30 UTC) #2
JoranSiu
4 years, 8 months ago (2016-03-31 22:16:43 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 00:36:53 UTC) #5
john.yan
lgtm
4 years, 8 months ago (2016-04-01 13:07:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848533006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848533006/20001
4 years, 8 months ago (2016-04-01 13:25:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-01 13:27:43 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 13:28:04 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c279138010961ef4040c8bfce790b8e1298cdfbc
Cr-Commit-Position: refs/heads/master@{#35206}

Powered by Google App Engine
This is Rietveld 408576698