Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: src/crankshaft/s390/lithium-codegen-s390.cc

Issue 1848533006: S390: Guard RISBG usage with facility check (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix typo with boolean operation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // 2 //
3 // Use of this source code is governed by a BSD-style license that can be 3 // Use of this source code is governed by a BSD-style license that can be
4 // found in the LICENSE file. 4 // found in the LICENSE file.
5 5
6 #include "src/crankshaft/s390/lithium-codegen-s390.h" 6 #include "src/crankshaft/s390/lithium-codegen-s390.h"
7 7
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 4211 matching lines...) Expand 10 before | Expand all | Expand 10 after
4222 LConstantOperand* const_operand = LConstantOperand::cast(instr->key()); 4222 LConstantOperand* const_operand = LConstantOperand::cast(instr->key());
4223 offset += ToInteger32(const_operand) * kPointerSize; 4223 offset += ToInteger32(const_operand) * kPointerSize;
4224 } else { 4224 } else {
4225 // Even though the HLoadKeyed instruction forces the input 4225 // Even though the HLoadKeyed instruction forces the input
4226 // representation for the key to be an integer, the input gets replaced 4226 // representation for the key to be an integer, the input gets replaced
4227 // during bound check elimination with the index argument to the bounds 4227 // during bound check elimination with the index argument to the bounds
4228 // check, which can be tagged, so that case must be handled here, too. 4228 // check, which can be tagged, so that case must be handled here, too.
4229 if (hinstr->key()->representation().IsSmi()) { 4229 if (hinstr->key()->representation().IsSmi()) {
4230 __ SmiToPtrArrayOffset(scratch, key); 4230 __ SmiToPtrArrayOffset(scratch, key);
4231 } else { 4231 } else {
4232 if (instr->hydrogen()->IsDehoisted()) { 4232 if (instr->hydrogen()->IsDehoisted() ||
4233 !CpuFeatures::IsSupported(GENERAL_INSTR_EXT)) {
4233 #if V8_TARGET_ARCH_S390X 4234 #if V8_TARGET_ARCH_S390X
4234 // If array access is dehoisted, the key, being an int32, can contain 4235 // If array access is dehoisted, the key, being an int32, can contain
4235 // a negative value, as needs to be sign-extended to 64-bit for 4236 // a negative value, as needs to be sign-extended to 64-bit for
4236 // memory access. 4237 // memory access.
4237 __ lgfr(key, key); 4238 __ lgfr(key, key);
4238 #endif 4239 #endif
4239 __ ShiftLeftP(scratch, key, Operand(kPointerSizeLog2)); 4240 __ ShiftLeftP(scratch, key, Operand(kPointerSizeLog2));
4240 } else { 4241 } else {
4241 // Small optimization to reduce pathlength. After Bounds Check, 4242 // Small optimization to reduce pathlength. After Bounds Check,
4242 // the key is guaranteed to be non-negative. Leverage RISBG, 4243 // the key is guaranteed to be non-negative. Leverage RISBG,
(...skipping 1418 matching lines...) Expand 10 before | Expand all | Expand 10 after
5661 __ LoadP(result, 5662 __ LoadP(result,
5662 FieldMemOperand(scratch, FixedArray::kHeaderSize - kPointerSize)); 5663 FieldMemOperand(scratch, FixedArray::kHeaderSize - kPointerSize));
5663 __ bind(deferred->exit()); 5664 __ bind(deferred->exit());
5664 __ bind(&done); 5665 __ bind(&done);
5665 } 5666 }
5666 5667
5667 #undef __ 5668 #undef __
5668 5669
5669 } // namespace internal 5670 } // namespace internal
5670 } // namespace v8 5671 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698