Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: Source/core/css/CSSBasicShapes.h

Issue 184853006: Remove unneeded destructors and add finalization support to various classes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/CSSCalculationValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSBasicShapes.h
diff --git a/Source/core/css/CSSBasicShapes.h b/Source/core/css/CSSBasicShapes.h
index 78b84df13d793817ce10a33bcdce42719be87afb..cab20cad15112185db076f4f570e2255d5932d1b 100644
--- a/Source/core/css/CSSBasicShapes.h
+++ b/Source/core/css/CSSBasicShapes.h
@@ -60,9 +60,6 @@ public:
virtual void trace(Visitor* visitor) { visitor->trace(m_layoutBox); }
-public:
- virtual ~CSSBasicShape() { }
kouhei (in TOK) 2014/03/05 07:05:01 Isn't this needed for RefCounted<CSSBasicType>, bu
zerny-chromium 2014/03/05 07:07:04 It is a no-op, so the default generated destructor
haraken 2014/03/05 07:09:15 Probably the default destructor is not virtual?
kouhei (in TOK) 2014/03/05 07:11:55 RefCountedBase's d-tor isn't declared virtual, and
-
protected:
CSSBasicShape() { }
RefPtrWillBeMember<CSSPrimitiveValue> m_layoutBox;
« no previous file with comments | « no previous file | Source/core/css/CSSCalculationValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698