Remove unneeded destructors and add finalization support to various classes.

Source/core/css/CSSBasicShapes.h

 /*
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 42 matching lines @@
 
     virtual Type type() const = 0;
     virtual String cssText() const = 0;
     virtual bool equals(const CSSBasicShape&) const = 0;
 
     CSSPrimitiveValue* layoutBox() const { return m_layoutBox.get(); }
     void setLayoutBox(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> layoutBox) { m_layoutBox = layoutBox; }
 
     virtual void trace(Visitor* visitor) { visitor->trace(m_layoutBox); }
 
-public:
-    virtual ~CSSBasicShape() { }

[kouhei (in TOK), 2014/03/05 07:05:01]

Isn't this needed for RefCounted<CSSBasicType>, built without enable_oilpan=1?

[zerny-chromium, 2014/03/05 07:07:04]

It is a no-op, so the default generated destructor should be sufficient. Is the
default not generated here for some reason?

[haraken, 2014/03/05 07:09:15]

Probably the default destructor is not virtual?

[kouhei (in TOK), 2014/03/05 07:11:55]

RefCountedBase's d-tor isn't declared virtual, and there are
RefPtr<CSSBasicShape>, so I thought derived classes' implicitly declared d-tor
like ~CSSBasicShapeRectangle() wouldn't be called without this explicit virtual
decl.

-
 protected:
     CSSBasicShape() { }
     RefPtrWillBeMember<CSSPrimitiveValue> m_layoutBox;
 };
 
 class CSSBasicShapeRectangle FINAL : public CSSBasicShape {
 public:
     static PassRefPtrWillBeRawPtr<CSSBasicShapeRectangle> create() { return adoptRefWillBeNoop(new CSSBasicShapeRectangle); }
 
     CSSPrimitiveValue* x() const { return m_x.get(); }
@@ skipping 270 matching lines @@
 
     RefPtrWillBeMember<CSSPrimitiveValue> m_topLeftRadius;
     RefPtrWillBeMember<CSSPrimitiveValue> m_topRightRadius;
     RefPtrWillBeMember<CSSPrimitiveValue> m_bottomRightRadius;
     RefPtrWillBeMember<CSSPrimitiveValue> m_bottomLeftRadius;
 };
 
 } // namespace WebCore
 
 #endif // CSSBasicShapes_h