Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1848443008: Simplify ScriptStreamer lifetime handling. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify ScriptStreamer lifetime handling. Remove manual keep-alive ref counting for ScriptStreamer across a posted task; unnecessary as the closure will keep a strong enough reference as-is. R=haraken BUG= Committed: https://crrev.com/dd34e5c065538d629cec415c5b26c165c7492f03 Cr-Commit-Position: refs/heads/master@{#384811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 5 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-02 15:05:50 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-02 16:23:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848443008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848443008/1
4 years, 8 months ago (2016-04-02 16:35:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 18:11:20 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 18:12:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd34e5c065538d629cec415c5b26c165c7492f03
Cr-Commit-Position: refs/heads/master@{#384811}

Powered by Google App Engine
This is Rietveld 408576698