third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp - Issue 1848443008: Simplify ScriptStreamer lifetime handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp

Issue 1848443008: Simplify ScriptStreamer lifetime handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp

index 5392ad2198bd3390f19154eef743a087ce88cd78..f28bcd30bf6960a676464786da4ec68d80def6d5 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp

@@ -76,7 +76,7 @@ WebThread& ScriptStreamerThread::platformThread()

return *m_thread;

}

-void ScriptStreamerThread::runScriptStreamingTask(WTF::PassOwnPtr<v8::ScriptCompiler::ScriptStreamingTask> task, ScriptStreamer* streamer)

+void ScriptStreamerThread::runScriptStreamingTask(PassOwnPtr<v8::ScriptCompiler::ScriptStreamingTask> task, ScriptStreamer* streamer)

{

TRACE_EVENT1("v8,devtools.timeline", "v8.parseOnBackground", "data", InspectorParseScriptEvent::data(streamer->scriptResourceIdentifier(), streamer->scriptURLString()));

// Running the task can and will block: SourceStream::GetSomeData will get

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.h ('k') | no next file » | no next file with comments »