Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1848313003: Fix error reporting for parallel parsed function blocks. (Closed)

Created:
4 years, 8 months ago by Karl
Modified:
4 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix error reporting for parallel parsed function blocks. Fixes error reporting in function blocks by adding a start address with parallel parses, and then using the getErrorBitNo() method of the bitstream cursor to correct error bit number, based on the start address. Dependent on CL https://codereview.chromium.org/1851163002. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4363 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2a9d186d1cb3eb75f90f2c82ec7c84ee06c3b569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M src/PNaClTranslator.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
A tests_lit/parse_errs/parallel.ll View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
4 years, 8 months ago (2016-04-01 21:35:34 UTC) #3
Jim Stichnoth
lgtm
4 years, 8 months ago (2016-04-01 23:53:47 UTC) #4
Karl
4 years, 8 months ago (2016-04-02 17:07:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a9d186d1cb3eb75f90f2c82ec7c84ee06c3b569 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698