Correct error reporting bit for parallel PNaCl bitcode parses.

Correct error reporting bit for parallel PNaCl bitcode parses.

This CL adds a way to deal with the fact that parallel parses of
function blocks (in PNaCl bitcode parsers) parse an extract buffer of
bits surrounding the function block.

It does this by adding the field ErrorOffset to a bitstream reader,
and the bitstream cursor function getErrorBitNo() to convert bit
positions in the bitstream reader by adding the number of bytes
specified by field ErrorOffset.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4363
R=stichnot@chromium.org

Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/34cb8ae903666b450f96df1b57ec31ae413216b7

[Karl, 2016-04-01 20:23:13]

Description was changed from

==========
Correct error reporting bit for parallel PNaCl bitcode parses.

This CL adds a way to deal with the fact that parallel parses of
function blocks (in PNaCl bitcode parsers) parse an extract buffer of
bits surrounding the function block.

It does this by adding the field ErrorOffset to a bitstream reader,
and the bitstream cursor function getErrorBitNo() to convert bit
positions in the bitstream reader by adding the number of bytes
specified by field ErrorOffset.

BUG=None
==========

to

==========
Correct error reporting bit for parallel PNaCl bitcode parses.

This CL adds a way to deal with the fact that parallel parses of
function blocks (in PNaCl bitcode parsers) parse an extract buffer of
bits surrounding the function block.

It does this by adding the field ErrorOffset to a bitstream reader,
and the bitstream cursor function getErrorBitNo() to convert bit
positions in the bitstream reader by adding the number of bytes
specified by field ErrorOffset.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4363
==========

[Karl, 2016-04-01 20:47:53]

kschimpf@google.com changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2016-04-01 23:52:30]

lgtm

https://codereview.chromium.org/1851163002/diff/40001/include/llvm/Bitcode/Na...
File include/llvm/Bitcode/NaCl/NaClBitstreamReader.h (right):

https://codereview.chromium.org/1851163002/diff/40001/include/llvm/Bitcode/Na...
include/llvm/Bitcode/NaCl/NaClBitstreamReader.h:235: size_t ErrorOffset;
Consider "size_t ErrorOffset = 0;" and then you can remove ErrorOffset(0) from 3
of the ctors.

Also, reflow comment.

[Karl, 2016-04-02 17:06:26]

Description was changed from

==========
Correct error reporting bit for parallel PNaCl bitcode parses.

This CL adds a way to deal with the fact that parallel parses of
function blocks (in PNaCl bitcode parsers) parse an extract buffer of
bits surrounding the function block.

It does this by adding the field ErrorOffset to a bitstream reader,
and the bitstream cursor function getErrorBitNo() to convert bit
positions in the bitstream reader by adding the number of bytes
specified by field ErrorOffset.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4363
==========

to

==========
Correct error reporting bit for parallel PNaCl bitcode parses.

This CL adds a way to deal with the fact that parallel parses of
function blocks (in PNaCl bitcode parsers) parse an extract buffer of
bits surrounding the function block.

It does this by adding the field ErrorOffset to a bitstream reader,
and the bitstream cursor function getErrorBitNo() to convert bit
positions in the bitstream reader by adding the number of bytes
specified by field ErrorOffset.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4363
R=stichnot@chromium.org

Committed:
https://chromium.googlesource.com/native_client/pnacl-llvm/+/34cb8ae903666b45...
==========

[Karl, 2016-04-02 17:06:28]

Committed patchset #4 (id:60001) manually as
34cb8ae903666b450f96df1b57ec31ae413216b7 (presubmit successful).

[Karl, 2016-04-02 17:16:50]

https://codereview.chromium.org/1851163002/diff/40001/include/llvm/Bitcode/Na...
File include/llvm/Bitcode/NaCl/NaClBitstreamReader.h (right):

https://codereview.chromium.org/1851163002/diff/40001/include/llvm/Bitcode/Na...
include/llvm/Bitcode/NaCl/NaClBitstreamReader.h:235: size_t ErrorOffset;
On 2016/04/01 23:52:30, stichnot wrote:
> Consider "size_t ErrorOffset = 0;" and then you can remove ErrorOffset(0) from
3
> of the ctors.
> 
> Also, reflow comment.

Done.