MIPS: [wasm] Implement Int32MulPair operator.

MIPS: [wasm] Implement Int32MulPair operator.

Port 40bdbef975779e41a7e81d3748342dd7da52977f

Implement Int32MulPair operator for MIPS.

BUG=

Committed: https://crrev.com/c9d1668f989986a9c1f1c151f5d2a4eee85bd9b2
Cr-Commit-Position: refs/heads/master@{#35256}

[Marija Antic, 2016-04-01 09:42:18]

marija.antic@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, balazs.kilvady@imgtec.com, gergely.kis@imgtec.com,
ilija.pavlovic@imgtec.com, ivica.bogosavljevic@imgtec.com,
miran.karic@imgtec.com

[Marija Antic, 2016-04-01 09:42:18]

PTAL

[ivica.bogosavljevic, 2016-04-01 11:00:12]

lgtm

[balazs.kilvady, 2016-04-01 12:16:21]

https://codereview.chromium.org/1848253002/diff/1/src/mips/macro-assembler-mi...
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/1848253002/diff/1/src/mips/macro-assembler-mi...
src/mips/macro-assembler-mips.cc:847: }
The 2 blocks are almost identical. What do you think about a simpler struct
like:
Register reg;
if (rt.is_reg()) {
  reg = rt.rm();
} else {
  reg = at;
  li(reg, rt);
}
// The 2nd block using reg <-> at.

[Ilija.Pavlovic1, 2016-04-04 10:27:26]

ilija.pavlovic@imgtec.com changed reviewers:
+ Ilija.Pavlovic@imgtec.com

[Ilija.Pavlovic1, 2016-04-04 10:27:26]

lgtm

[miran.karic, 2016-04-04 14:36:03]

miran.karic@imgtec.com changed reviewers:
- Ilija.Pavlovic@imgtec.com

[miran.karic, 2016-04-04 14:36:04]

https://codereview.chromium.org/1848253002/diff/1/test/cctest/compiler/test-r...
File test/cctest/compiler/test-run-machops.cc (right):

https://codereview.chromium.org/1848253002/diff/1/test/cctest/compiler/test-r...
test/cctest/compiler/test-run-machops.cc:7: #include <iostream>
Is this needed?

[Marija Antic, 2016-04-05 07:50:04]

Addressed the comments. Also, removed test file changes, in order to avoid
waiting on external review twice. All lowering operator tests will be enabled by
https://codereview.chromium.org/1819383002/

https://codereview.chromium.org/1848253002/diff/1/src/mips/macro-assembler-mi...
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/1848253002/diff/1/src/mips/macro-assembler-mi...
src/mips/macro-assembler-mips.cc:847: }
On 2016/04/01 12:16:21, balazs.kilvady wrote:
> The 2 blocks are almost identical. What do you think about a simpler struct
> like:
> Register reg;
> if (rt.is_reg()) {
>   reg = rt.rm();
> } else {
>   reg = at;
>   li(reg, rt);
> }
> // The 2nd block using reg <-> at. 

Done.

https://codereview.chromium.org/1848253002/diff/1/test/cctest/compiler/test-r...
File test/cctest/compiler/test-run-machops.cc (right):

https://codereview.chromium.org/1848253002/diff/1/test/cctest/compiler/test-r...
test/cctest/compiler/test-run-machops.cc:7: #include <iostream>
On 2016/04/04 14:36:03, miran.karic wrote:
> Is this needed?

Done.

[Marija Antic, 2016-04-05 07:51:37]

The CQ bit was checked by marija.antic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 07:51:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848253002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848253002/40001

[commit-bot: I haz the power, 2016-04-05 07:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 07:51:47]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[balazs.kilvady, 2016-04-05 10:49:50]

LGTM with a nit:
As the original CL is landed the 'Port for <url>' should be changed to
Port 40bdbef975779e41a7e81d3748342dd7da52977f

[Marija Antic, 2016-04-05 10:50:43]

Description was changed from

==========
MIPS: [wasm] Implement Int32MulPair operator.

Port of https://codereview.chromium.org/1807273002/

Implement Int32MulPair operator for MIPS.

BUG=
==========

to

==========
MIPS: [wasm] Implement Int32MulPair operator.

Port 40bdbef975779e41a7e81d3748342dd7da52977f

Implement Int32MulPair operator for MIPS.

BUG=
==========

[Marija Antic, 2016-04-05 10:50:57]

The CQ bit was checked by marija.antic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 10:51:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848253002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848253002/40001

[commit-bot: I haz the power, 2016-04-05 11:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 11:19:34]

Dry run: This issue passed the CQ dry run.

[Marija Antic, 2016-04-05 11:19:55]

The CQ bit was checked by marija.antic@imgtec.com

[Marija Antic, 2016-04-05 11:19:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
ivica.bogosavljevic@imgtec.com, Ilija.Pavlovic@imgtec.com
Link to the patchset: https://codereview.chromium.org/1848253002/#ps40001
(title: "Remove test file changes")

[commit-bot: I haz the power, 2016-04-05 11:20:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848253002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848253002/40001

[commit-bot: I haz the power, 2016-04-05 11:21:42]

Description was changed from

==========
MIPS: [wasm] Implement Int32MulPair operator.

Port 40bdbef975779e41a7e81d3748342dd7da52977f

Implement Int32MulPair operator for MIPS.

BUG=
==========

to

==========
MIPS: [wasm] Implement Int32MulPair operator.

Port 40bdbef975779e41a7e81d3748342dd7da52977f

Implement Int32MulPair operator for MIPS.

BUG=
==========

[commit-bot: I haz the power, 2016-04-05 11:21:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-05 11:22:15]

Description was changed from

==========
MIPS: [wasm] Implement Int32MulPair operator.

Port 40bdbef975779e41a7e81d3748342dd7da52977f

Implement Int32MulPair operator for MIPS.

BUG=
==========

to

==========
MIPS: [wasm] Implement Int32MulPair operator.

Port 40bdbef975779e41a7e81d3748342dd7da52977f

Implement Int32MulPair operator for MIPS.

BUG=

Committed: https://crrev.com/c9d1668f989986a9c1f1c151f5d2a4eee85bd9b2
Cr-Commit-Position: refs/heads/master@{#35256}
==========

[commit-bot: I haz the power, 2016-04-05 11:22:16]

Patchset 3 (id:??) landed as
https://crrev.com/c9d1668f989986a9c1f1c151f5d2a4eee85bd9b2
Cr-Commit-Position: refs/heads/master@{#35256}