Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184823002: DevTools: do not cache details node, remove linkifier from presentation record. (Closed)

Created:
6 years, 9 months ago by pfeldman
Modified:
6 years, 9 months ago
Reviewers:
caseq, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: do not cache details node, remove linkifier from presentation record. R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168281

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : Review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -99 lines) Patch
M LayoutTests/inspector/timeline/timeline-node-reference.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/TimelinePanel.js View 4 chunks +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/TimelinePresentationModel.js View 1 2 18 chunks +59 lines, -82 lines 0 comments Download
M Source/devtools/front_end/TimelineUIUtils.js View 1 2 6 chunks +18 lines, -7 lines 0 comments Download
M Source/devtools/front_end/TimelineView.js View 1 9 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pfeldman
6 years, 9 months ago (2014-02-28 18:35:26 UTC) #1
caseq
https://codereview.chromium.org/184823002/diff/20001/Source/devtools/front_end/TimelinePresentationModel.js File Source/devtools/front_end/TimelinePresentationModel.js (right): https://codereview.chromium.org/184823002/diff/20001/Source/devtools/front_end/TimelinePresentationModel.js#newcode1157 Source/devtools/front_end/TimelinePresentationModel.js:1157: for (var key in this._record.data) Use Object.values()? https://codereview.chromium.org/184823002/diff/20001/Source/devtools/front_end/TimelineUIUtils.js File ...
6 years, 9 months ago (2014-03-03 07:53:15 UTC) #2
caseq
lgtm given the problems are fixed.
6 years, 9 months ago (2014-03-03 08:30:44 UTC) #3
pfeldman
https://codereview.chromium.org/184823002/diff/20001/Source/devtools/front_end/TimelinePresentationModel.js File Source/devtools/front_end/TimelinePresentationModel.js (right): https://codereview.chromium.org/184823002/diff/20001/Source/devtools/front_end/TimelinePresentationModel.js#newcode1157 Source/devtools/front_end/TimelinePresentationModel.js:1157: for (var key in this._record.data) On 2014/03/03 07:53:15, caseq ...
6 years, 9 months ago (2014-03-03 09:16:48 UTC) #4
pfeldman
6 years, 9 months ago (2014-03-03 09:20:26 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r168281 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698