LayoutTests/inspector/timeline/timeline-node-reference.html - Issue 184823002: DevTools: do not cache details node, remove linkifier from presentation record.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/timeline/timeline-node-reference.html

Issue 184823002: DevTools: do not cache details node, remove linkifier from presentation record. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Review comments addressed. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/inspector/timeline/timeline-node-reference.html

diff --git a/LayoutTests/inspector/timeline/timeline-node-reference.html b/LayoutTests/inspector/timeline/timeline-node-reference.html

index 0291fa1a8e193fd38377891584625fcf6b481777..b63f6e2e361fff41c20b8fabd16f966a30b134a6 100644

--- a/LayoutTests/inspector/timeline/timeline-node-reference.html

+++ b/LayoutTests/inspector/timeline/timeline-node-reference.html

@@ -29,7 +29,7 @@ function test()

function clickValueLink(record, row)

{

- var helper = record.generatePopupContent(onDetailsContentReady);

+ var helper = record.generatePopupContent(new WebInspector.Linkifier(), onDetailsContentReady);

function onDetailsContentReady(element)

{

« no previous file with comments | « no previous file | Source/devtools/front_end/TimelinePanel.js » ('j') | no next file with comments »