Initialize child framesets when they become part of the parent frameset grid.

Initialize child framesets when they become part of the parent frameset grid.

The number of child frames and framesets in a parent frameset grid may be
increased by a script after initial layout. Framesets that initially were not
part of the grid were left uninitialized, i.e. their GridAxis objects are
empty, and the layout object size is 0x0. As soon as such a frameset becomes
part of the grid later on, it typically gets a size, which positionFrames()
will detect and lay it out. However, since zero-width columns and zero-height
rows are allowed, if the size of the child frameset remains at 0x0, we cannot
just base the need for layout (which initializes the frame sets) on them
getting a new size.

BUG=594834
Committed: https://crrev.com/95a6fd5887a9f1101be12815863fe2a9e4a07fdd
Cr-Commit-Position: refs/heads/master@{#385404}

[mstensho (USE GERRIT), 2016-04-01 12:21:46]

mstensho@opera.com changed reviewers:
+ eae@chromium.org

[mstensho (USE GERRIT), 2016-04-01 12:21:47]

https://codereview.chromium.org/1848033004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp (right):

https://codereview.chromium.org/1848033004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp:425: if (size !=
child->size() || size.isEmpty()) {
This is the simplest fix that I can think of. A safer but slightly uglier fix
could be to condition the child on being a LayoutFrameSet without rows() and
cols() initialized. But hopefully what I'm doing here doesn't have any unwanted
side-effects (performance-wise or other-wise)?

[eae, 2016-04-05 21:11:26]

LGTM

[eae, 2016-04-05 21:11:30]

The CQ bit was checked by eae@chromium.org

[eae, 2016-04-05 21:11:37]

Thanks Morten!

[commit-bot: I haz the power, 2016-04-05 21:12:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848033004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848033004/1

[commit-bot: I haz the power, 2016-04-05 22:30:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 22:30:31]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mstensho (USE GERRIT), 2016-04-06 07:55:18]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-04-06 07:55:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848033004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848033004/1

[commit-bot: I haz the power, 2016-04-06 08:52:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-06 08:54:05]

Description was changed from

==========
Initialize child framesets when they become part of the parent frameset grid.

The number of child frames and framesets in a parent frameset grid may be
increased by a script after initial layout. Framesets that initially were not
part of the grid were left uninitialized, i.e. their GridAxis objects are
empty, and the layout object size is 0x0. As soon as such a frameset becomes
part of the grid later on, it typically gets a size, which positionFrames()
will detect and lay it out. However, since zero-width columns and zero-height
rows are allowed, if the size of the child frameset remains at 0x0, we cannot
just base the need for layout (which initializes the frame sets) on them
getting a new size.

BUG=594834
==========

to

==========
Initialize child framesets when they become part of the parent frameset grid.

The number of child frames and framesets in a parent frameset grid may be
increased by a script after initial layout. Framesets that initially were not
part of the grid were left uninitialized, i.e. their GridAxis objects are
empty, and the layout object size is 0x0. As soon as such a frameset becomes
part of the grid later on, it typically gets a size, which positionFrames()
will detect and lay it out. However, since zero-width columns and zero-height
rows are allowed, if the size of the child frameset remains at 0x0, we cannot
just base the need for layout (which initializes the frame sets) on them
getting a new size.

BUG=594834

Committed: https://crrev.com/95a6fd5887a9f1101be12815863fe2a9e4a07fdd
Cr-Commit-Position: refs/heads/master@{#385404}
==========

[commit-bot: I haz the power, 2016-04-06 08:54:06]

Patchset 1 (id:??) landed as
https://crrev.com/95a6fd5887a9f1101be12815863fe2a9e4a07fdd
Cr-Commit-Position: refs/heads/master@{#385404}