third_party/WebKit/LayoutTests/fast/frames/expand-grid-with-zero-size-child-frameset-crash.html - Issue 1848033004: Initialize child framesets when they become part of the parent frameset grid.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/frames/expand-grid-with-zero-size-child-frameset-crash.html

Issue 1848033004: Initialize child framesets when they become part of the parent frameset grid. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/frames/expand-grid-with-zero-size-child-frameset-crash-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutFrameSet.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <script>

	2 if (window.testRunner)

	3 testRunner.dumpAsText();

	4 onload = ()=> {

	5 // Force layout first.

	6 document.documentElement.offsetTop;

	7

	8 // Then expand the root frameset grid from 2x1 to 2x2.

	9 document.getElementById("rootSet").setAttribute("rows", "*, 0");

	10 }

	11 </script>

	12 <frameset id="rootSet" cols="0, *">

	13 <frame id="firstChild"></frame>

	14 <frame src="data:text/html,PASS if no crash or assertion failure."></frame>

	15 <frameset>

	16 <frame src="data:text/html,3"></frame>

	17 </frameset>

	18 </frameset>

OLD	NEW