Report wrong async function result type as type error in checked mode (Fixes #26133).

Report wrong async function result type as type error in checked mode (Fixes #26133).
Add regression test.

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/508b876ec8ff84a774accff97554e434d399f34d

[regis, 2016-05-09 20:07:36]

regis@google.com changed reviewers:
+ hausner@google.com

[hausner, 2016-05-09 21:42:34]

LGTM

https://codereview.chromium.org/1847953002/diff/40001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1847953002/diff/40001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:10052: LetNode* checked_expr = new(Z)
LetNode(statement_pos);
Should this point to the expression being returned (expr_pos) instead of the
return statement? If so, ditto below in a few places.

[regis, 2016-05-09 21:58:23]

Thanks!

https://codereview.chromium.org/1847953002/diff/40001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1847953002/diff/40001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:10052: LetNode* checked_expr = new(Z)
LetNode(statement_pos);
On 2016/05/09 21:42:34, hausner wrote:
> Should this point to the expression being returned (expr_pos) instead of the
> return statement? If so, ditto below in a few places.

Good point! I replaced all occurrences of statement_pos by expr_pos.

[regis, 2016-05-09 22:06:49]

Description was changed from

==========
Report wrong async function result type as type error in checked mode (Fixes
#26133).
Add regression test.
==========

to

==========
Report wrong async function result type as type error in checked mode (Fixes
#26133).
Add regression test.

R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/508b876ec8ff84a774accff97554e434d399f34d
==========

[regis, 2016-05-09 22:06:51]

Committed patchset #4 (id:60001) manually as
508b876ec8ff84a774accff97554e434d399f34d (presubmit successful).