Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2905)

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp

Issue 1847863002: Move notification resource loading from content/child to blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Call stop when all fetches have finished. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
index 2e82f636155df855d69dd6a1789aed0c8d70f67b..2cc2c06e441e13fcd1e3f3101de4a198bfcee8ed 100644
--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
@@ -132,11 +132,13 @@ DocumentThreadableLoader::DocumentThreadableLoader(Document& document, Threadabl
, m_redirectMode(WebURLRequest::FetchRedirectModeFollow)
, m_weakFactory(this)
{
+ LOG(WARNING) << __FUNCTION__;
Peter Beverloo 2016/04/15 11:07:29 I presume this is for figuring out the ASAN proble
Michael van Ouwerkerk 2016/04/18 11:26:53 Acknowledged.
ASSERT(client);
}
void DocumentThreadableLoader::start(const ResourceRequest& request)
{
+ LOG(WARNING) << __FUNCTION__;
// Setting an outgoing referer is only supported in the async code path.
ASSERT(m_async || request.httpReferrer().isEmpty());
@@ -308,6 +310,7 @@ void DocumentThreadableLoader::makeCrossOriginAccessRequest(const ResourceReques
DocumentThreadableLoader::~DocumentThreadableLoader()
{
+ LOG(WARNING) << __FUNCTION__;
m_client = nullptr;
// TODO(oilpan): Remove this once DocumentThreadableLoader is once again a ResourceOwner.
@@ -342,6 +345,7 @@ void DocumentThreadableLoader::overrideTimeout(unsigned long timeoutMilliseconds
void DocumentThreadableLoader::cancel()
{
+ LOG(WARNING) << __FUNCTION__;
cancelWithError(ResourceError());
// |this| may be dead here.
}

Powered by Google App Engine
This is Rietveld 408576698