Move Character.h from platform/fonts to platform/text

Move Character.h from platform/fonts to platform/text

TBR=eae
BUG=600976
Committed: https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072
Cr-Commit-Position: refs/heads/master@{#385698}

[Seigo Nonaka, 2016-04-01 07:27:36]

nona@chromium.org changed reviewers:
+ tkent@chromium.org

[Seigo Nonaka, 2016-04-01 07:27:36]

Hi Kent-san,

This is TODO in http://codereview.chromium.org/1844663002
I'm going to rebase once the CL is grabbed by trybots.

Could you kindly take a look?

Thank you.

[tkent, 2016-04-01 07:47:46]

tkent@chromium.org changed reviewers:
+ kojii@chromium.org

[tkent, 2016-04-01 07:47:56]

kojii@, is this ok?

[kojii, 2016-04-05 03:35:52]

kojii@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[kojii, 2016-04-05 03:36:28]

non-owner lgtm, but I'd like drott@ to have a look before landing.

drott@, PTAL?

[drott, 2016-04-05 15:54:07]

LGTM, thanks.

[eae, 2016-04-05 20:45:16]

The fonts/text separation is a bit odd today, there are more things in fonts/
that would be a better fit for text. The entire shaping directory might also
make more sense in text/

[Seigo Nonaka, 2016-04-06 10:49:59]

On 2016/04/05 20:45:16, eae wrote:
> The fonts/text separation is a bit odd today, there are more things in fonts/
> that would be a better fit for text. The entire shaping directory might also
> make more sense in text/

Thank you for your comment but I'm sorry I'm not so familiar with the context of
platform/fonts/shaping and platform/fonts relationship.
At this moment, can I move only Character.h to platform/text?
For shaping directory, I created a bug for it: http://crbug.com/600976

Thank you.

[Seigo Nonaka, 2016-04-06 10:50:12]

Description was changed from

==========
Move Character.h from platform/fonts to platform/text
==========

to

==========
Move Character.h from platform/fonts to platform/text

BUG=600976
==========

[drott, 2016-04-06 22:39:48]

On 2016/04/06 at 10:49:59, nona wrote:
> On 2016/04/05 20:45:16, eae wrote:
> > The fonts/text separation is a bit odd today, there are more things in
fonts/
> > that would be a better fit for text. The entire shaping directory might also
> > make more sense in text/
> 
> Thank you for your comment but I'm sorry I'm not so familiar with the context
of platform/fonts/shaping and platform/fonts relationship.
> At this moment, can I move only Character.h to platform/text?

If I interpret eae@'s comment correctly, yes. I think what he meant to say is
that there might be a need for more moving, as you noted in the bug. So, I'd say
go ahead.

[kojii, 2016-04-07 01:20:40]

On 2016/04/06 at 22:39:48, drott wrote:
> 
> If I interpret eae@'s comment correctly, yes. I think what he meant to say is
that there might be a need for more moving, as you noted in the bug. So, I'd say
go ahead.

eae@, this CL needs the magic word from a core owner. I suppose you meant ok
with this change to go ahead?

[eae, 2016-04-07 05:48:48]

Yes, sorry about the confusion! Thanks for doing this!

[eae, 2016-04-07 05:49:00]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-04-07 05:49:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847853004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847853004/1

[commit-bot: I haz the power, 2016-04-07 05:51:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 05:51:50]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Seigo Nonaka, 2016-04-07 05:54:38]

Thank you for your reply!
Looks like I need to rebase to master.
Will upload latest patch.

Thank you!

[Seigo Nonaka, 2016-04-07 06:48:28]

The CQ bit was checked by nona@chromium.org

[Seigo Nonaka, 2016-04-07 06:48:29]

The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org,
kojii@chromium.org
Link to the patchset: https://codereview.chromium.org/1847853004/#ps40001
(title: "rebase again")

[commit-bot: I haz the power, 2016-04-07 06:48:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847853004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847853004/40001

[commit-bot: I haz the power, 2016-04-07 06:57:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 06:57:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Seigo Nonaka, 2016-04-07 06:58:46]

Description was changed from

==========
Move Character.h from platform/fonts to platform/text

BUG=600976
==========

to

==========
Move Character.h from platform/fonts to platform/text

TBR=eae
BUG=600976
==========

[Seigo Nonaka, 2016-04-07 07:00:34]

TBR-ing to eae@ based on reply in the review comment.
Also changes in core/ is only include path change.

[Seigo Nonaka, 2016-04-07 07:00:42]

The CQ bit was checked by nona@chromium.org

[commit-bot: I haz the power, 2016-04-07 07:00:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847853004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847853004/40001

[eae, 2016-04-07 07:51:42]

LGTM

[commit-bot: I haz the power, 2016-04-07 09:25:54]

Description was changed from

==========
Move Character.h from platform/fonts to platform/text

TBR=eae
BUG=600976
==========

to

==========
Move Character.h from platform/fonts to platform/text

TBR=eae
BUG=600976
==========

[commit-bot: I haz the power, 2016-04-07 09:25:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-07 09:28:46]

Description was changed from

==========
Move Character.h from platform/fonts to platform/text

TBR=eae
BUG=600976
==========

to

==========
Move Character.h from platform/fonts to platform/text

TBR=eae
BUG=600976

Committed: https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072
Cr-Commit-Position: refs/heads/master@{#385698}
==========

[commit-bot: I haz the power, 2016-04-07 09:28:48]

Patchset 3 (id:??) landed as
https://crrev.com/47ae6230898a93adc77339a6995aef25022a3072
Cr-Commit-Position: refs/heads/master@{#385698}