Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1847823007: Hide PingLoader lifetime implementation detail from outside view. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
tkent, haraken
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide PingLoader lifetime implementation detail from outside view. The self-sustaining nature of ping loader objects while the request is in-flight is an internal implementation detail. Reflect that by having the class type derive from just GarbageCollectedFinalized> and instead internally manually manage a SelfKeepAlive<> reference. R=haraken BUG= Committed: https://crrev.com/4fdc302b6281499d53be92dcf151c91d51362235 Cr-Commit-Position: refs/heads/master@{#384810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M third_party/WebKit/Source/core/loader/BeaconLoader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. Moving one step closer to retiring RefCountedGarbageCollected<>..
4 years, 8 months ago (2016-04-02 15:28:11 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-02 16:22:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847823007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847823007/1
4 years, 8 months ago (2016-04-02 16:34:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 17:39:20 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 17:40:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fdc302b6281499d53be92dcf151c91d51362235
Cr-Commit-Position: refs/heads/master@{#384810}

Powered by Google App Engine
This is Rietveld 408576698