Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/Source/core/loader/PingLoader.h

Issue 1847823007: Hide PingLoader lifetime implementation detail from outside view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/PingLoader.h
diff --git a/third_party/WebKit/Source/core/loader/PingLoader.h b/third_party/WebKit/Source/core/loader/PingLoader.h
index 3350441709737f56ad5cf8257f221a5ed973576d..056c3a5325ec9606b00a528e4568f5675d86fcef 100644
--- a/third_party/WebKit/Source/core/loader/PingLoader.h
+++ b/third_party/WebKit/Source/core/loader/PingLoader.h
@@ -57,7 +57,7 @@ class ResourceRequest;
// The ping loader is used by audit pings, beacon transmissions and image loads
// during page unloading.
//
-class CORE_EXPORT PingLoader : public RefCountedGarbageCollected<PingLoader>, public LocalFrameLifecycleObserver, private WebURLLoaderClient {
+class CORE_EXPORT PingLoader : public GarbageCollectedFinalized<PingLoader>, public LocalFrameLifecycleObserver, private WebURLLoaderClient {
USING_GARBAGE_COLLECTED_MIXIN(PingLoader);
WTF_MAKE_NONCOPYABLE(PingLoader);
public:
@@ -98,6 +98,7 @@ private:
Timer<PingLoader> m_timeout;
String m_url;
unsigned long m_identifier;
+ SelfKeepAlive<PingLoader> m_keepAlive;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/loader/BeaconLoader.cpp ('k') | third_party/WebKit/Source/core/loader/PingLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698